[GitHub] [arrow] jorisvandenbossche commented on a diff in pull request #34249: GH-34248: [C++] Add an order_by node

["jorisvandenbossche (via GitHub)" <gi...@apache.org>]

jorisvandenbossche commented on code in PR #34249:
URL: https://github.com/apache/arrow/pull/34249#discussion_r1135194997


##########
cpp/src/arrow/compute/exec/options.h:
##########
@@ -402,6 +402,14 @@ class ARROW_EXPORT OrderBySinkNodeOptions : public SinkNodeOptions {
   SortOptions sort_options;
 };
 
+class ARROW_EXPORT OrderByNodeOptions : public ExecNodeOptions {
+ public:
+  static constexpr std::string_view kName = "order_by";
+  explicit OrderByNodeOptions(Ordering ordering) : ordering(std::move(ordering)) {}
+
+  Ordering ordering;

Review Comment:
   The OrderBySinkNode is using `SortOptions` as argument instead of `Ordering`, but looking into those two classes, that should basically be equivalent? (`SortOptions` also accepts a vector of `SortKey` and a `null_placement` arg, just as the Ordering class)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org