[GitHub] [flink] Airblader commented on a change in pull request #18293: [FLINK-25560][Connectors/HBase] Add "sink.delete.mode" in HBase sql connector for retracting the latest version or all versions in changelog mode.

[GitBox <gi...@apache.org>]

Airblader commented on a change in pull request #18293:
URL: https://github.com/apache/flink/pull/18293#discussion_r780318078



##########
File path: flink-connectors/flink-connector-hbase-base/src/main/java/org/apache/flink/connector/hbase/table/HBaseConnectorOptions.java
##########
@@ -87,6 +90,17 @@
                                     + "Can be set to '0' to disable it. Note, both 'sink.buffer-flush.max-size' and 'sink.buffer-flush.max-rows' "
                                     + "can be set to '0' with the flush interval set allowing for complete async processing of buffered actions.");
 
+    public static final ConfigOption<String> SINK_DELETE_MODE =
+            ConfigOptions.key("sink.delete.mode")
+                    .stringType()

Review comment:
       Wouldn't it be better to use `enumType` here since the option is an enum? Then we can also improve the docs on the option by documenting the enum itself (which should be PublicEvolving), and avoid duplicating the entire thing as string constants.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org