[GitHub] [incubator-nuttx] GUIDINGLI commented on a change in pull request #5848: local_socket: default set block mode if accept() a new socket

[GitBox <gi...@apache.org>]

GUIDINGLI commented on a change in pull request #5848:
URL: https://github.com/apache/incubator-nuttx/pull/5848#discussion_r836270411



##########
File path: net/local/local_sockif.c
##########
@@ -718,6 +718,17 @@ static int local_ioctl(FAR struct socket *psock, int cmd,
 
   switch (cmd)
     {
+      case FIONBIO:
+        if (conn->lc_infile.f_inode != NULL)
+          {
+            ret = file_ioctl(&conn->lc_infile, cmd, arg);
+          }
+
+        if (conn->lc_outfile.f_inode != NULL)
+          {
+            ret = file_ioctl(&conn->lc_outfile, cmd, arg);
+          }

Review comment:
       That's not right if write like that.
   
   The local socket has two pipe connections, both of the need to be set.
   
   I did some small change, please see the new version.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org