You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "mobuchowski (via GitHub)" <gi...@apache.org> on 2023/02/14 10:32:31 UTC
[GitHub] [airflow] mobuchowski opened a new pull request, #29528: newsfragments: add missing 29289 newsfragment
mobuchowski opened a new pull request, #29528:
URL: https://github.com/apache/airflow/pull/29528
Add missing newsfragments for PR #29289
Signed-off-by: Maciej Obuchowski <ob...@gmail.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mobuchowski commented on a diff in pull request #29528: newsfragments: add missing 29289 newsfragment
Posted by "mobuchowski (via GitHub)" <gi...@apache.org>.
mobuchowski commented on code in PR #29528:
URL: https://github.com/apache/airflow/pull/29528#discussion_r1107187260
##########
newsfragments/29289.significant.rst:
##########
@@ -0,0 +1,12 @@
+Listener API, which previously used SqlAlchemy events to be notified about
+TaskInstance state changes, now is being directly called by Airflow.
+The changes do not affect actual Listener API structure, but significantly
+increase developer and user experience while using it.
+
+This assures Listener gets as close as possible Task object to what's
+actually executed - which set up mapped tasks, rendered Jinja templates
+and all the non-db members set up.
+
+Additionally, it allows listeners to operate outside of the SqlAlchemy
+database transaction. Doing work in context of active transaction previously
+caused a number of bugs and can lead to stuck connection as in #28431.
Review Comment:
Thanks, I'll close the PR then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #29528: newsfragments: add missing 29289 newsfragment
Posted by "ephraimbuddy (via GitHub)" <gi...@apache.org>.
ephraimbuddy commented on code in PR #29528:
URL: https://github.com/apache/airflow/pull/29528#discussion_r1106985299
##########
newsfragments/29289.significant.rst:
##########
@@ -0,0 +1,12 @@
+Listener API, which previously used SqlAlchemy events to be notified about
+TaskInstance state changes, now is being directly called by Airflow.
+The changes do not affect actual Listener API structure, but significantly
+increase developer and user experience while using it.
+
+This assures Listener gets as close as possible Task object to what's
+actually executed - which set up mapped tasks, rendered Jinja templates
+and all the non-db members set up.
+
+Additionally, it allows listeners to operate outside of the SqlAlchemy
+database transaction. Doing work in context of active transaction previously
+caused a number of bugs and can lead to stuck connection as in #28431.
Review Comment:
From what you explained above, looks like there's nothing breaking users should be careful about. If that's the case, we don't need a newsfragment. Sorry to bother you on this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mobuchowski closed pull request #29528: newsfragments: add missing 29289 newsfragment
Posted by "mobuchowski (via GitHub)" <gi...@apache.org>.
mobuchowski closed pull request #29528: newsfragments: add missing 29289 newsfragment
URL: https://github.com/apache/airflow/pull/29528
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org