[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1267: MINIFICPP-1758 - Log c2 responses

[GitBox <gi...@apache.org>]

adamdebreceni commented on a change in pull request #1267:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1267#discussion_r831899625



##########
File path: extensions/http-curl/protocols/RESTSender.cpp
##########
@@ -161,6 +161,7 @@ C2Payload RESTSender::sendPayload(const std::string url, const Direction directi
     logger_->log_debug("Response code '" "%" PRId64 "' from '%s'", respCode, url);
   }
   const auto response_body_bytes = gsl::make_span(client.getResponseBody()).as_span<const std::byte>();
+  logger_->log_trace("Received response: \"%s\"", [&] {return utils::StringUtils::escapeUnprintableBytes(response_body_bytes);});

Review comment:
       I think this feature concerns all c2 responses, not only heartbeat responses (e.g. acknowledge responses, I could imagine something useful be included in the response, like invalid operation id or the like)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org