You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by al...@apache.org on 2017/10/18 17:44:28 UTC

[1/3] mesos git commit: Increased level of verbose logs for libprocess actor state transitions.

Repository: mesos
Updated Branches:
  refs/heads/master a7de1bccd -> 41193181d


Increased level of verbose logs for libprocess actor state transitions.

Increases vlog level of some recurring events to improve readability.
Specifically, we now log the following events on vlog level three
instead of level two:
  "Spawned process <process>",
  "Resuming <process>",
  "Cleaning up <process>",
  "Donating thread to <process> while waiting".

This does not imply a general change or a holistic approach concerning
the libprocess verbose logs.

Review: https://reviews.apache.org/r/62891/


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/6630e764
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/6630e764
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/6630e764

Branch: refs/heads/master
Commit: 6630e764a4531894c4f6df8d44fcf1427efb3a5a
Parents: a7de1bc
Author: Armand Grillet <ag...@mesosphere.io>
Authored: Wed Oct 18 10:38:17 2017 -0700
Committer: Alexander Rukletsov <al...@apache.org>
Committed: Wed Oct 18 10:38:17 2017 -0700

----------------------------------------------------------------------
 3rdparty/libprocess/src/process.cpp | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/6630e764/3rdparty/libprocess/src/process.cpp
----------------------------------------------------------------------
diff --git a/3rdparty/libprocess/src/process.cpp b/3rdparty/libprocess/src/process.cpp
index a81ef74..2334e26 100644
--- a/3rdparty/libprocess/src/process.cpp
+++ b/3rdparty/libprocess/src/process.cpp
@@ -3232,7 +3232,7 @@ UPID ProcessManager::spawn(ProcessBase* process, bool manage)
   // Add process to the run queue (so 'initialize' will get invoked).
   enqueue(process);
 
-  VLOG(2) << "Spawned process " << pid;
+  VLOG(3) << "Spawned process " << pid;
 
   return pid;
 }
@@ -3242,7 +3242,7 @@ void ProcessManager::resume(ProcessBase* process)
 {
   __process__ = process;
 
-  VLOG(2) << "Resuming " << process->pid << " at " << Clock::now();
+  VLOG(3) << "Resuming " << process->pid << " at " << Clock::now();
 
   bool terminate = false;
   bool blocked = false;
@@ -3380,7 +3380,7 @@ void ProcessManager::resume(ProcessBase* process)
 
 void ProcessManager::cleanup(ProcessBase* process)
 {
-  VLOG(2) << "Cleaning up " << process->pid;
+  VLOG(3) << "Cleaning up " << process->pid;
 
   // Invariant today is that all processes must be initialized and
   // have their state transition to READY before being terminated.
@@ -3552,7 +3552,7 @@ bool ProcessManager::wait(const UPID& pid)
   }
 
   if (process != nullptr) {
-    VLOG(2) << "Donating thread to " << process->pid << " while waiting";
+    VLOG(3) << "Donating thread to " << process->pid << " while waiting";
     ProcessBase* donator = __process__;
     resume(process);
     running.fetch_sub(1);


[2/3] mesos git commit: Increased level of some verbose logs from allocator.

Posted by al...@apache.org.
Increased level of some verbose logs from allocator.

Increases vlog level of some recurring events to improve readability.
Specifically, we now log the following events on vlog level two
instead of level one:
  "Skipped allocation because the allocator is paused",
  "No allocations performed",
  "No inverse offers to send out!".

Review: https://reviews.apache.org/r/62886/


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/3edce398
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/3edce398
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/3edce398

Branch: refs/heads/master
Commit: 3edce39840f6a825df5fb44aab59e317a55008f1
Parents: 6630e76
Author: Armand Grillet <ag...@mesosphere.io>
Authored: Wed Oct 18 10:38:29 2017 -0700
Committer: Alexander Rukletsov <al...@apache.org>
Committed: Wed Oct 18 10:38:29 2017 -0700

----------------------------------------------------------------------
 src/master/allocator/mesos/hierarchical.cpp | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/3edce398/src/master/allocator/mesos/hierarchical.cpp
----------------------------------------------------------------------
diff --git a/src/master/allocator/mesos/hierarchical.cpp b/src/master/allocator/mesos/hierarchical.cpp
index 4453074..5b6efe5 100644
--- a/src/master/allocator/mesos/hierarchical.cpp
+++ b/src/master/allocator/mesos/hierarchical.cpp
@@ -1444,7 +1444,7 @@ Future<Nothing> HierarchicalAllocatorProcess::allocate(
     const hashset<SlaveID>& slaveIds)
 {
   if (paused) {
-    VLOG(1) << "Skipped allocation because the allocator is paused";
+    VLOG(2) << "Skipped allocation because the allocator is paused";
 
     return Nothing();
   }
@@ -1465,7 +1465,7 @@ Nothing HierarchicalAllocatorProcess::_allocate()
   metrics.allocation_run_latency.stop();
 
   if (paused) {
-    VLOG(1) << "Skipped allocation because the allocator is paused";
+    VLOG(2) << "Skipped allocation because the allocator is paused";
 
     return Nothing();
   }
@@ -1942,7 +1942,7 @@ void HierarchicalAllocatorProcess::__allocate()
   }
 
   if (offerable.empty()) {
-    VLOG(1) << "No allocations performed";
+    VLOG(2) << "No allocations performed";
   } else {
     // Now offer the resources to each framework.
     foreachkey (const FrameworkID& frameworkId, offerable) {
@@ -2032,7 +2032,7 @@ void HierarchicalAllocatorProcess::deallocate()
   }
 
   if (offerable.empty()) {
-    VLOG(1) << "No inverse offers to send out!";
+    VLOG(2) << "No inverse offers to send out!";
   } else {
     // Now send inverse offers to each framework.
     foreachkey (const FrameworkID& frameworkId, offerable) {


[3/3] mesos git commit: Increased level of some verbose logs from master and agent.

Posted by al...@apache.org.
Increased level of some verbose logs from master and agent.

Increases vlog level of some recurring events to improve readability.
Specifically, we now log the following events on vlog level two
instead of level one:
  "Sending heartbeat",
  "Received ping from <slave-observer>",
  "Querying resource estimator for oversubscribable resources",
  "Received oversubscribable resources".

Review: https://reviews.apache.org/r/62887/


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/41193181
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/41193181
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/41193181

Branch: refs/heads/master
Commit: 41193181d6b75eeecae2729bf98007d9318e351a
Parents: 3edce39
Author: Armand Grillet <ag...@mesosphere.io>
Authored: Wed Oct 18 10:38:42 2017 -0700
Committer: Alexander Rukletsov <al...@apache.org>
Committed: Wed Oct 18 10:38:42 2017 -0700

----------------------------------------------------------------------
 src/master/master.hpp | 2 +-
 src/slave/slave.cpp   | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/41193181/src/master/master.hpp
----------------------------------------------------------------------
diff --git a/src/master/master.hpp b/src/master/master.hpp
index 0ddc982..a3c9530 100644
--- a/src/master/master.hpp
+++ b/src/master/master.hpp
@@ -346,7 +346,7 @@ private:
   {
     // Only send a heartbeat if the connection is not closed.
     if (http.closed().isPending()) {
-      VLOG(1) << "Sending heartbeat to " << logMessage;
+      VLOG(2) << "Sending heartbeat to " << logMessage;
 
       Message message(heartbeatMessage);
       http.send<Message, Event>(message);

http://git-wip-us.apache.org/repos/asf/mesos/blob/41193181/src/slave/slave.cpp
----------------------------------------------------------------------
diff --git a/src/slave/slave.cpp b/src/slave/slave.cpp
index 4d7dc8e..d8477b4 100644
--- a/src/slave/slave.cpp
+++ b/src/slave/slave.cpp
@@ -4963,7 +4963,7 @@ void Slave::executorMessage(
 // within that (more generous) timeout.
 void Slave::ping(const UPID& from, bool connected)
 {
-  VLOG(1) << "Received ping from " << from;
+  VLOG(2) << "Received ping from " << from;
 
   if (!connected && state == RUNNING) {
     // This could happen if there is a one-way partition between
@@ -6489,7 +6489,7 @@ Future<Nothing> Slave::garbageCollect(const string& path)
 
 void Slave::forwardOversubscribed()
 {
-  VLOG(1) << "Querying resource estimator for oversubscribable resources";
+  VLOG(2) << "Querying resource estimator for oversubscribable resources";
 
   resourceEstimator->oversubscribable()
     .onAny(defer(self(), &Self::_forwardOversubscribed, lambda::_1));
@@ -6503,7 +6503,7 @@ void Slave::_forwardOversubscribed(const Future<Resources>& oversubscribable)
                << (oversubscribable.isFailed()
                    ? oversubscribable.failure() : "future discarded");
   } else {
-    VLOG(1) << "Received oversubscribable resources "
+    VLOG(2) << "Received oversubscribable resources "
             << oversubscribable.get() << " from the resource estimator";
 
     // Oversubscribable resources must be tagged as revocable.