You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "deepaktaker (via GitHub)" <gi...@apache.org> on 2026/02/12 10:18:55 UTC
[PR] CAMEL-22978 : Fix quoted boolean parameter matching in PropertyBindingSupport [camel]
deepaktaker opened a new pull request, #21422:
URL: https://github.com/apache/camel/pull/21422
The getValidParameterType method was treating quoted boolean values ("true", 'false') as String.class
This caused constructor/factory method parameter matching to fail when a boolean parameter was expected
The fix extracts the quoted content and checks if it's a boolean value (case-insensitive)
Added tests for both constructor and factory method scenarios
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-22978 : Fix quoted boolean parameter matching in PropertyBindingSupport [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21422:
URL: https://github.com/apache/camel/pull/21422#issuecomment-3889980877
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
* You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
* :warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-22978 : Fix quoted boolean parameter matching in PropertyBindingSupport [camel]
Posted by "deepaktaker (via GitHub)" <gi...@apache.org>.
deepaktaker commented on PR #21422:
URL: https://github.com/apache/camel/pull/21422#issuecomment-3890179452
> booleans should not be in quotes, you dont do that in java.
Thanks for the feedback! I understand the concern, but this isn't about intentionally quoting booleans in Java code.
The issue comes up in Camel Spring XML DSL when defining bean constructors:
<camel:constructor index="0" value="false"/>
XML attributes are inherently strings, so the parser passes "false" to PropertyBindingSupport. Without this fix, the method returns String.class instead of Boolean.class, and factory method resolution fails.
We hit this in production - the only workaround was to patch this method. Same situation would apply to YAML DSL or properties-based configuration where values come in as strings.
Happy to discuss further if needed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-22978 : Fix quoted boolean parameter matching in PropertyBindingSupport [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #21422:
URL: https://github.com/apache/camel/pull/21422#issuecomment-3890103148
booleans should not be in quotes, you dont do that in java.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-22978 : Fix quoted boolean parameter matching in PropertyBindingSupport [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #21422:
URL: https://github.com/apache/camel/pull/21422
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org