You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by vi...@apache.org on 2017/04/13 22:53:46 UTC

[4/5] mesos git commit: Updated a health checker test to enable executor authentication.

Updated a health checker test to enable executor authentication.

This patch updates the test
`HealthCheckTest.DefaultExecutorCommandHealthCheck` to
enable authentication on the agent operator API when
Mesos has been built with SSL.

Review: https://reviews.apache.org/r/58370/


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/04be349f
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/04be349f
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/04be349f

Branch: refs/heads/master
Commit: 04be349fe0d87239455202dc1ef5e4f44f100861
Parents: 8c18f62
Author: Greg Mann <gr...@mesosphere.io>
Authored: Thu Apr 13 15:49:53 2017 -0700
Committer: Vinod Kone <vi...@gmail.com>
Committed: Thu Apr 13 15:49:53 2017 -0700

----------------------------------------------------------------------
 src/tests/health_check_tests.cpp | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/04be349f/src/tests/health_check_tests.cpp
----------------------------------------------------------------------
diff --git a/src/tests/health_check_tests.cpp b/src/tests/health_check_tests.cpp
index c5857b2..3bba1bb 100644
--- a/src/tests/health_check_tests.cpp
+++ b/src/tests/health_check_tests.cpp
@@ -2146,9 +2146,14 @@ TEST_F_TEMP_DISABLED_ON_WINDOWS(
   Try<Owned<cluster::Master>> master = StartMaster();
   ASSERT_SOME(master);
 
-  // Disable AuthN on the agent.
   slave::Flags flags = CreateSlaveFlags();
+#ifndef USE_SSL_SOCKET
+  // Disable operator API authentication for the default executor. Executor
+  // authentication currently has SSL as a dependency, so we cannot require
+  // executors to authenticate with the agent operator API if Mesos was not
+  // built with SSL support.
   flags.authenticate_http_readwrite = false;
+#endif // USE_SSL_SOCKET
 
   Fetcher fetcher;