[GitHub] [spark] nchammas commented on a change in pull request #27928: [SPARK-31167][BUILD] Refactor how we track Python test/build dependencies

[GitBox <gi...@apache.org>]

nchammas commented on a change in pull request #27928: [SPARK-31167][BUILD] Refactor how we track Python test/build dependencies
URL: https://github.com/apache/spark/pull/27928#discussion_r401802338
 
 

 ##########
 File path: docs/README.md
 ##########
 @@ -88,7 +88,7 @@ Note: Other versions of roxygen2 might work in SparkR documentation generation b
 To generate API docs for any language, you'll need to install these libraries:
 
 ```sh
-pip install sphinx==2.3.1 mkdocs==1.0.4 numpy==1.18.1
+pip install -r ./dev/requirements.txt
 
 Review comment:
   Following from the comments by @cloud-fan [here](https://github.com/apache/spark/pull/27534#issuecomment-607011028) and [here](https://github.com/apache/spark/pull/28088#discussion_r401342910), and taking into account your request as well, I think we need to maintain two versions of the requirements file, one without pinning for dev purposes, and one with pinning for CI and the release machinery.
   
   I will implement this using pip-tools, following the examples set by Warehouse and Trio which I referenced earlier in this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org