You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/11/09 13:42:06 UTC
[GitHub] [fineract] ruchiD opened a new pull request, #2737: FINERACT-1734-Deliquency-range-event
ruchiD opened a new pull request, #2737:
URL: https://github.com/apache/fineract/pull/2737
## Description
Describe the changes made and why they were made.
1.Created new Avro schema for LoanAccountDelinquencyRangeDataV1 having id, accountno, externalId, delinquencyRange
2.Created new event for LoanDelinquencyRangeChangeBusinessEvent
3.Created Serializer and mapper for LoanAccountDelinquencyRangeDataV1
4.Modified DeliquencyWritePlatformServiceImpl for raising LoanDelinquencyRangeChangeBusinessEvent for loan if Range Changes.
5.Added event configuration
6.Unit Tests
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics merged pull request #2737: FINERACT-1734-Deliquency-range-event
Posted by GitBox <gi...@apache.org>.
galovics merged PR #2737:
URL: https://github.com/apache/fineract/pull/2737
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on a diff in pull request #2737: FINERACT-1734-Deliquency-range-event
Posted by GitBox <gi...@apache.org>.
galovics commented on code in PR #2737:
URL: https://github.com/apache/fineract/pull/2737#discussion_r1018891140
##########
fineract-avro-schemas/src/main/avro/loan/v1/LoanAccountDelinquencyRangeDataV1.avsc:
##########
@@ -0,0 +1,39 @@
+{
+ "name": "LoanAccountDelinquencyRangeDataV1",
+ "namespace": "org.apache.fineract.avro.loan.v1",
+ "type": "record",
+ "fields": [
+ {
+ "default": null,
+ "name": "id",
+ "type": [
+ "null",
+ "int"
Review Comment:
Shouldn't this be a long?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org