You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/12/13 17:17:17 UTC

[GitHub] [apisix-helm-chart] shreemaan-abhishek commented on a diff in pull request #19: feat: support to expose admin api

shreemaan-abhishek commented on code in PR #19:
URL: https://github.com/apache/apisix-helm-chart/pull/19#discussion_r1047471439


##########
chart/apisix/values.yaml:
##########
@@ -97,6 +97,15 @@ dns:
 admin:
   # Enable Admin API
   enabled: true
+  # admin service type
+  type: ClusterIP
+  # loadBalancerIP: a.b.c.d
+  # loadBalancerSourceRanges:
+  #   - "143.231.0.0/16"

Review Comment:
   @membphis why are these comments needed? 🤔 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org