[GitHub] [flink-statefun] igalshilman commented on a change in pull request #36: [FLINK-16123] Add auto-routable Protobuf Kafka ingress

[GitBox <gi...@apache.org>]

igalshilman commented on a change in pull request #36: [FLINK-16123] Add auto-routable Protobuf Kafka ingress
URL: https://github.com/apache/flink-statefun/pull/36#discussion_r384464348
 
 

 ##########
 File path: statefun-flink/statefun-flink-io-bundle/src/main/java/org/apache/flink/statefun/flink/io/kafka/KafkaSpecJsonParser.java
 ##########
 @@ -71,6 +75,32 @@ private KafkaSpecJsonParser() {}
     return Selectors.textListAt(json, TOPICS_POINTER);
   }
 
+  static Map<String, RoutingConfig> routableTopics(JsonNode json) {
+    Map<String, RoutingConfig> routableTopics = new HashMap<>();
+    for (JsonNode routableTopicNode : Selectors.listAt(json, TOPICS_POINTER)) {
+      final String topic = Selectors.textAt(routableTopicNode, JsonPointer.compile("/topic"));
+      final String typeUrl = Selectors.textAt(routableTopicNode, JsonPointer.compile("/typeUrl"));
+      final List<TargetFunctionType> targets = new ArrayList<>();
+      for (String namespaceAndName :
 
 Review comment:
   I think that this method can be made slightly more readable by moving this `for` to its own method. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services