You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/10/11 11:24:15 UTC

[GitHub] [hudi] wulei0302 commented on a diff in pull request #6916: [HUDI-5003] Fix the type of InLineFileSystem`startOffset to long

wulei0302 commented on code in PR #6916:
URL: https://github.com/apache/hudi/pull/6916#discussion_r992192606


##########
hudi-common/src/main/java/org/apache/hudi/common/fs/inline/InLineFsDataInputStream.java:
##########
@@ -33,11 +33,11 @@
  */
 public class InLineFsDataInputStream extends FSDataInputStream {
 
-  private final int startOffset;
+  private final long startOffset;
   private final FSDataInputStream outerStream;
   private final int length;

Review Comment:
   **length** be **int** type is ok,  which in the FSDataInputStream(Hadoop) is also **int**.   **length** as maximum number of bytes to read be **int** type may by enough.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org