You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "waitingkuo (via GitHub)" <gi...@apache.org> on 2023/04/07 11:38:12 UTC

[GitHub] [arrow-datafusion] waitingkuo commented on pull request #5906: add with_timezone

waitingkuo commented on PR #5906:
URL: https://github.com/apache/arrow-datafusion/pull/5906#issuecomment-1500209232

   > Thanks @waitingkuo --
   > 
   > Even though `arrow_cast` could (and probably should) be updated to support timezones having a specific WITH_TIMEZONE seems like a good idea to me as it will be a better experience
   > 
   > I think this PR needs
   > 
   > 1. Get the type correct (I left a comment about how to do this)
   > 2. Add an entry to `WITH_TIMEZONE` the user documentation (e.g. https://github.com/apache/arrow-datafusion/blob/f00ef9d5484039dc7013af5b8fa04f7b29ffaba7/docs/source/user-guide/sql/scalar_functions.md?plain=1#L1208
   >    )
   
   Hi @alamb thanks, in fact i'm working on adding timezone support for `arrow_cast` now, will send a pr soon


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org