You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2016/06/09 22:47:44 UTC

[Impala-CR](cdh5-trunk) IMPALA-1240: add back spilling sort now that sorter is not flaky 

Tim Armstrong has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3356

Change subject: IMPALA-1240: add back spilling sort now that sorter is not flaky
......................................................................

IMPALA-1240: add back spilling sort now that sorter is not flaky

This test coverage was removed because of flakiness.
Instead of mem_limit, use max_block_mgr_memory, which is more
deterministic since it isn't affected by scanner memory usage.
Now that the sorter is more stable, this test should reliably
succeed.

Change-Id: I88056db2eac3fa91bef85284a516be303f25333d
---
M tests/query_test/test_cancellation.py
1 file changed, 19 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/56/3356/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3356
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I88056db2eac3fa91bef85284a516be303f25333d
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>

[Impala-CR](cdh5-trunk) IMPALA-1240: add back spilling sort now that sorter is not flaky

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-1240: add back spilling sort now that sorter is not flaky
......................................................................


Patch Set 1:

For context, this was originally removed in this commit:

commit 4e843487b27b07dd144be689aad3a1bfeb5ad499
Author: Dan Hecht <dh...@cloudera.com>
Date:   Tue Sep 16 16:23:44 2014 -0700

    IMPALA-1240: TestCancellationFullSort hits mem limit of 300MB with tpch_parquet
    
    The test sets a mem_limit of 300MB and does:
    
       delay(t)
       assert(query_state != EXCEPTION)
       cancel()
    
    If the mem_limit is hit before the delay completes, the assert will fail.  So,
    the test is racy.  It appears we are right on the 300 MB memory limit (on my
    machine, the query completes with peak mem usage in the high 200 MB).
    
    I'm not sure why the mem_limit dimension was added, but given that it makes
    the test racy and doesn't seem to add value, let's remove it and re-enable the
    test.
    
    Change-Id: I63767161bec6d7d6cd3de2e4563425297ffccb0d
    Reviewed-on: http://gerrit.sjc.cloudera.com:8080/4366
    Reviewed-by: Alex Behm <al...@cloudera.com>
    Tested-by: jenkins
    (cherry picked from commit e876c9e3f6ae4a6914c0d0976eb89dc45b8802b2)
    Reviewed-on: http://gerrit.sjc.cloudera.com:8080/4375
    Reviewed-by: Daniel Hecht <dh...@cloudera.com>

-- 
To view, visit http://gerrit.cloudera.org:8080/3356
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I88056db2eac3fa91bef85284a516be303f25333d
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No

[Impala-CR](cdh5-trunk) IMPALA-1240: add back spilling sort now that sorter is not flaky

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has abandoned this change.

Change subject: IMPALA-1240: add back spilling sort now that sorter is not flaky
......................................................................


Abandoned

Moved to asf repo: https://gerrit.cloudera.org/#/c/3795/1

-- 
To view, visit http://gerrit.cloudera.org:8080/3356
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I88056db2eac3fa91bef85284a516be303f25333d
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-CR](cdh5-trunk) IMPALA-1240: add back spilling sort now that sorter is not flaky

Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change.

Change subject: IMPALA-1240: add back spilling sort now that sorter is not flaky
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/3356
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I88056db2eac3fa91bef85284a516be303f25333d
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No