You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Jothi Padmanabhan <jo...@gmail.com> on 2014/12/15 09:28:24 UTC
Review Request 29036: Lens-104. Add session service to server-api
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29036/
-----------------------------------------------------------
Review request for lens.
Bugs: lens-104
https://issues.apache.org/jira/browse/lens-104
Repository: lens
Description
-------
Lens-104. Add session service to server-api
Diffs
-----
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java f45fe3c
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 4d4bb53
lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java 29dc669
Diff: https://reviews.apache.org/r/29036/diff/
Testing
-------
Changes are in interface, no new tests added. Also, did not change the TestSessionUI and TestServerRestart as they seem to be testing the internals of the HiveSessionService implementation
Thanks,
Jothi Padmanabhan
Re: Review Request 29036: Lens-104. Add session service to server-api
Posted by Jothi Padmanabhan <jo...@gmail.com>.
> On Dec. 15, 2014, 8:34 a.m., Jaideep dhok wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java, line 28
> > <https://reviews.apache.org/r/29036/diff/1/?file=791656#file791656line28>
> >
> > Since service lookup is by name, it would be useful to move HiveSessionService.NAME to the interface.
Will do. I saw that Metastore service did not have a name in the service definition. But now I do see that the other names are in the service defintion. And it makes sense
- Jothi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29036/#review65075
-----------------------------------------------------------
On Dec. 15, 2014, 8:28 a.m., Jothi Padmanabhan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29036/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2014, 8:28 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: lens-104
> https://issues.apache.org/jira/browse/lens-104
>
>
> Repository: lens
>
>
> Description
> -------
>
> Lens-104. Add session service to server-api
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java f45fe3c
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 4d4bb53
> lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java 29dc669
>
> Diff: https://reviews.apache.org/r/29036/diff/
>
>
> Testing
> -------
>
> Changes are in interface, no new tests added. Also, did not change the TestSessionUI and TestServerRestart as they seem to be testing the internals of the HiveSessionService implementation
>
>
> Thanks,
>
> Jothi Padmanabhan
>
>
Re: Review Request 29036: Lens-104. Add session service to server-api
Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29036/#review65075
-----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java
<https://reviews.apache.org/r/29036/#comment108016>
Since service lookup is by name, it would be useful to move HiveSessionService.NAME to the interface.
- Jaideep dhok
On Dec. 15, 2014, 8:28 a.m., Jothi Padmanabhan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29036/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2014, 8:28 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: lens-104
> https://issues.apache.org/jira/browse/lens-104
>
>
> Repository: lens
>
>
> Description
> -------
>
> Lens-104. Add session service to server-api
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java f45fe3c
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 4d4bb53
> lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java 29dc669
>
> Diff: https://reviews.apache.org/r/29036/diff/
>
>
> Testing
> -------
>
> Changes are in interface, no new tests added. Also, did not change the TestSessionUI and TestServerRestart as they seem to be testing the internals of the HiveSessionService implementation
>
>
> Thanks,
>
> Jothi Padmanabhan
>
>
Re: Review Request 29036: Lens-104. Add session service to server-api
Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29036/#review65090
-----------------------------------------------------------
Ship it!
Ship It!
- Jaideep dhok
On Dec. 15, 2014, 3:06 p.m., Jothi Padmanabhan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29036/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2014, 3:06 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: lens-104
> https://issues.apache.org/jira/browse/lens-104
>
>
> Repository: lens
>
>
> Description
> -------
>
> Lens-104. Add session service to server-api
>
>
> Diffs
> -----
>
> lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLResource.java a0abe93
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java f45fe3c
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 4d4bb53
> lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java 29dc669
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 10f65b2
>
> Diff: https://reviews.apache.org/r/29036/diff/
>
>
> Testing
> -------
>
> Changes are in interface, no new tests added. Also, did not change the TestSessionUI and TestServerRestart as they seem to be testing the internals of the HiveSessionService implementation
>
>
> Thanks,
>
> Jothi Padmanabhan
>
>
Re: Review Request 29036: Lens-104. Add session service to server-api
Posted by Jothi Padmanabhan <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29036/
-----------------------------------------------------------
(Updated Dec. 15, 2014, 3:06 p.m.)
Review request for lens.
Bugs: lens-104
https://issues.apache.org/jira/browse/lens-104
Repository: lens
Description
-------
Lens-104. Add session service to server-api
Diffs (updated)
-----
lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLResource.java a0abe93
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java f45fe3c
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 4d4bb53
lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java 29dc669
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 10f65b2
Diff: https://reviews.apache.org/r/29036/diff/
Testing
-------
Changes are in interface, no new tests added. Also, did not change the TestSessionUI and TestServerRestart as they seem to be testing the internals of the HiveSessionService implementation
Thanks,
Jothi Padmanabhan