You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2020/04/21 20:00:11 UTC
Review Request 72409: Added intro docs on running workloads.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72409/
-----------------------------------------------------------
Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim Harper.
Bugs: MESOS-10115
https://issues.apache.org/jira/browse/MESOS-10115
Repository: mesos
Description
-------
This adds a new document containing an introduction for
scheduler authors to the available methods for running
workloads in a Mesos cluster.
Diffs
-----
docs/home.md 027319fa28abbdac21588ad1c62dae588033f60e
docs/running-workloads.md PRE-CREATION
Diff: https://reviews.apache.org/r/72409/diff/1/
Testing
-------
Viewed with `site/mesos-website-dev.sh`
Thanks,
Greg Mann
Re: Review Request 72409: Added intro docs on running workloads.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72409/#review220547
-----------------------------------------------------------
Ship it!
Ship It!
- Qian Zhang
On April 29, 2020, 8:01 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72409/
> -----------------------------------------------------------
>
> (Updated April 29, 2020, 8:01 a.m.)
>
>
> Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim Harper.
>
>
> Bugs: MESOS-10115
> https://issues.apache.org/jira/browse/MESOS-10115
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds a new document containing an introduction for
> scheduler authors to the available methods for running
> workloads in a Mesos cluster.
>
>
> Diffs
> -----
>
> docs/home.md 027319fa28abbdac21588ad1c62dae588033f60e
> docs/running-workloads.md PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72409/diff/3/
>
>
> Testing
> -------
>
> Viewed with `site/mesos-website-dev.sh`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72409: Added intro docs on running workloads.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72409/
-----------------------------------------------------------
(Updated April 29, 2020, 12:01 a.m.)
Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim Harper.
Bugs: MESOS-10115
https://issues.apache.org/jira/browse/MESOS-10115
Repository: mesos
Description
-------
This adds a new document containing an introduction for
scheduler authors to the available methods for running
workloads in a Mesos cluster.
Diffs (updated)
-----
docs/home.md 027319fa28abbdac21588ad1c62dae588033f60e
docs/running-workloads.md PRE-CREATION
Diff: https://reviews.apache.org/r/72409/diff/3/
Changes: https://reviews.apache.org/r/72409/diff/2-3/
Testing
-------
Viewed with `site/mesos-website-dev.sh`
Thanks,
Greg Mann
Re: Review Request 72409: Added intro docs on running workloads.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72409/
-----------------------------------------------------------
(Updated April 27, 2020, 11:57 p.m.)
Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim Harper.
Bugs: MESOS-10115
https://issues.apache.org/jira/browse/MESOS-10115
Repository: mesos
Description
-------
This adds a new document containing an introduction for
scheduler authors to the available methods for running
workloads in a Mesos cluster.
Diffs (updated)
-----
docs/home.md 027319fa28abbdac21588ad1c62dae588033f60e
docs/running-workloads.md PRE-CREATION
Diff: https://reviews.apache.org/r/72409/diff/2/
Changes: https://reviews.apache.org/r/72409/diff/1-2/
Testing
-------
Viewed with `site/mesos-website-dev.sh`
Thanks,
Greg Mann
Re: Review Request 72409: Added intro docs on running workloads.
Posted by Qian Zhang <zh...@gmail.com>.
> On April 22, 2020, 10:09 p.m., Qian Zhang wrote:
> > docs/running-workloads.md
> > Lines 65-67 (patched)
> > <https://reviews.apache.org/r/72409/diff/1/?file=2224549#file2224549line65>
> >
> > Do we want to mention how we set OOM score adjustment for burstable tasks somewhere in the doc?
> >
> > And I think we also need to describe the newly introduced `REASON_CONTAINER_MEMORY_REQUEST_EXCEEDED` in the doc `task-state-reasons.md`.
>
> Greg Mann wrote:
> I added these to https://reviews.apache.org/r/72410/ as well
Yeah, I see you added how we set OOM score adjustment in `nested-container-and-task-group.md` which is specific for nested container, but we also set OOM score adjustment for burstable command tasks.
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72409/#review220424
-----------------------------------------------------------
On April 28, 2020, 7:57 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72409/
> -----------------------------------------------------------
>
> (Updated April 28, 2020, 7:57 a.m.)
>
>
> Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim Harper.
>
>
> Bugs: MESOS-10115
> https://issues.apache.org/jira/browse/MESOS-10115
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds a new document containing an introduction for
> scheduler authors to the available methods for running
> workloads in a Mesos cluster.
>
>
> Diffs
> -----
>
> docs/home.md 027319fa28abbdac21588ad1c62dae588033f60e
> docs/running-workloads.md PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72409/diff/2/
>
>
> Testing
> -------
>
> Viewed with `site/mesos-website-dev.sh`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72409: Added intro docs on running workloads.
Posted by Greg Mann <gr...@mesosphere.io>.
> On April 22, 2020, 2:09 p.m., Qian Zhang wrote:
> > docs/running-workloads.md
> > Lines 65-67 (patched)
> > <https://reviews.apache.org/r/72409/diff/1/?file=2224549#file2224549line65>
> >
> > Do we want to mention how we set OOM score adjustment for burstable tasks somewhere in the doc?
> >
> > And I think we also need to describe the newly introduced `REASON_CONTAINER_MEMORY_REQUEST_EXCEEDED` in the doc `task-state-reasons.md`.
>
> Greg Mann wrote:
> I added these to https://reviews.apache.org/r/72410/ as well
>
> Qian Zhang wrote:
> Yeah, I see you added how we set OOM score adjustment in `nested-container-and-task-group.md` which is specific for nested container, but we also set OOM score adjustment for burstable command tasks.
I added a clarification in the command task section saying that fields in the task message do the same thing in that case, that seems sufficient to me?
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72409/#review220424
-----------------------------------------------------------
On April 29, 2020, 12:01 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72409/
> -----------------------------------------------------------
>
> (Updated April 29, 2020, 12:01 a.m.)
>
>
> Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim Harper.
>
>
> Bugs: MESOS-10115
> https://issues.apache.org/jira/browse/MESOS-10115
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds a new document containing an introduction for
> scheduler authors to the available methods for running
> workloads in a Mesos cluster.
>
>
> Diffs
> -----
>
> docs/home.md 027319fa28abbdac21588ad1c62dae588033f60e
> docs/running-workloads.md PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72409/diff/3/
>
>
> Testing
> -------
>
> Viewed with `site/mesos-website-dev.sh`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72409: Added intro docs on running workloads.
Posted by Greg Mann <gr...@mesosphere.io>.
> On April 22, 2020, 2:09 p.m., Qian Zhang wrote:
> > docs/running-workloads.md
> > Lines 57 (patched)
> > <https://reviews.apache.org/r/72409/diff/1/?file=2224549#file2224549line57>
> >
> > I think we also need to mention this new feature (task resource limits support) in `upgrades.md`.
I added this to https://reviews.apache.org/r/72410/
> On April 22, 2020, 2:09 p.m., Qian Zhang wrote:
> > docs/running-workloads.md
> > Lines 65-67 (patched)
> > <https://reviews.apache.org/r/72409/diff/1/?file=2224549#file2224549line65>
> >
> > Do we want to mention how we set OOM score adjustment for burstable tasks somewhere in the doc?
> >
> > And I think we also need to describe the newly introduced `REASON_CONTAINER_MEMORY_REQUEST_EXCEEDED` in the doc `task-state-reasons.md`.
I added these to https://reviews.apache.org/r/72410/ as well
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72409/#review220424
-----------------------------------------------------------
On April 27, 2020, 11:57 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72409/
> -----------------------------------------------------------
>
> (Updated April 27, 2020, 11:57 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim Harper.
>
>
> Bugs: MESOS-10115
> https://issues.apache.org/jira/browse/MESOS-10115
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds a new document containing an introduction for
> scheduler authors to the available methods for running
> workloads in a Mesos cluster.
>
>
> Diffs
> -----
>
> docs/home.md 027319fa28abbdac21588ad1c62dae588033f60e
> docs/running-workloads.md PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72409/diff/2/
>
>
> Testing
> -------
>
> Viewed with `site/mesos-website-dev.sh`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72409: Added intro docs on running workloads.
Posted by Qian Zhang <zh...@gmail.com>.
> On April 22, 2020, 10:09 p.m., Qian Zhang wrote:
> > docs/running-workloads.md
> > Lines 65-67 (patched)
> > <https://reviews.apache.org/r/72409/diff/1/?file=2224549#file2224549line65>
> >
> > Do we want to mention how we set OOM score adjustment for burstable tasks somewhere in the doc?
> >
> > And I think we also need to describe the newly introduced `REASON_CONTAINER_MEMORY_REQUEST_EXCEEDED` in the doc `task-state-reasons.md`.
>
> Greg Mann wrote:
> I added these to https://reviews.apache.org/r/72410/ as well
>
> Qian Zhang wrote:
> Yeah, I see you added how we set OOM score adjustment in `nested-container-and-task-group.md` which is specific for nested container, but we also set OOM score adjustment for burstable command tasks.
>
> Greg Mann wrote:
> I added a clarification in the command task section saying that fields in the task message do the same thing in that case, that seems sufficient to me?
Sounds good to me.
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72409/#review220424
-----------------------------------------------------------
On April 29, 2020, 8:01 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72409/
> -----------------------------------------------------------
>
> (Updated April 29, 2020, 8:01 a.m.)
>
>
> Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim Harper.
>
>
> Bugs: MESOS-10115
> https://issues.apache.org/jira/browse/MESOS-10115
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds a new document containing an introduction for
> scheduler authors to the available methods for running
> workloads in a Mesos cluster.
>
>
> Diffs
> -----
>
> docs/home.md 027319fa28abbdac21588ad1c62dae588033f60e
> docs/running-workloads.md PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72409/diff/3/
>
>
> Testing
> -------
>
> Viewed with `site/mesos-website-dev.sh`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72409: Added intro docs on running workloads.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72409/#review220424
-----------------------------------------------------------
docs/running-workloads.md
Lines 57 (patched)
<https://reviews.apache.org/r/72409/#comment308811>
I think we also need to mention this new feature (task resource limits support) in `upgrades.md`.
docs/running-workloads.md
Lines 65-67 (patched)
<https://reviews.apache.org/r/72409/#comment308810>
Do we want to mention how we set OOM score adjustment for burstable tasks somewhere in the doc?
And I think we also need to describe the newly introduced `REASON_CONTAINER_MEMORY_REQUEST_EXCEEDED` in the doc `task-state-reasons.md`.
- Qian Zhang
On April 22, 2020, 4 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72409/
> -----------------------------------------------------------
>
> (Updated April 22, 2020, 4 a.m.)
>
>
> Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim Harper.
>
>
> Bugs: MESOS-10115
> https://issues.apache.org/jira/browse/MESOS-10115
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds a new document containing an introduction for
> scheduler authors to the available methods for running
> workloads in a Mesos cluster.
>
>
> Diffs
> -----
>
> docs/home.md 027319fa28abbdac21588ad1c62dae588033f60e
> docs/running-workloads.md PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72409/diff/1/
>
>
> Testing
> -------
>
> Viewed with `site/mesos-website-dev.sh`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72409: Added intro docs on running workloads.
Posted by Qian Zhang <zh...@gmail.com>.
> On April 22, 2020, 9:21 p.m., Qian Zhang wrote:
> > docs/running-workloads.md
> > Lines 30 (patched)
> > <https://reviews.apache.org/r/72409/diff/1/?file=2224549#file2224549line30>
> >
> > What do you mean for "task is specified with executor ID"? Why do we want to specify an executor ID for a task?
>
> Greg Mann wrote:
> In the LAUNCH_GROUP call, one or more tasks is specified along with an executor info, so there is always an executor ID specified.
>
> Greg Mann wrote:
> I updated the text to hopefully make this a little clearer, let me know what you think.
>
> Qian Zhang wrote:
> I see the updated text is:
> > When one task is specified with an executor that has a unique executor ID
>
> But IIUC, for the `LAUNCH_GROUP` call, the executor is not specified to the individual task (i.e., `TaskInfo.executor`) in the task group, instead it is specified in the `LaunchGroup` protobuf message, right?
> ```
> message LaunchGroup {
> required ExecutorInfo executor = 1;
> required TaskGroupInfo task_group = 2;
> }
> ```
>
> Greg Mann wrote:
> Yes, I think the language "one task is specified with an executor" makes sense in that context.
>
> Greg Mann wrote:
> Hm, maybe I'll change it to "one task is specified alongside an executor" to make the distinction clearer?
Yes!
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72409/#review220420
-----------------------------------------------------------
On April 29, 2020, 8:01 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72409/
> -----------------------------------------------------------
>
> (Updated April 29, 2020, 8:01 a.m.)
>
>
> Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim Harper.
>
>
> Bugs: MESOS-10115
> https://issues.apache.org/jira/browse/MESOS-10115
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds a new document containing an introduction for
> scheduler authors to the available methods for running
> workloads in a Mesos cluster.
>
>
> Diffs
> -----
>
> docs/home.md 027319fa28abbdac21588ad1c62dae588033f60e
> docs/running-workloads.md PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72409/diff/3/
>
>
> Testing
> -------
>
> Viewed with `site/mesos-website-dev.sh`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72409: Added intro docs on running workloads.
Posted by Qian Zhang <zh...@gmail.com>.
> On April 22, 2020, 9:21 p.m., Qian Zhang wrote:
> > docs/running-workloads.md
> > Lines 30 (patched)
> > <https://reviews.apache.org/r/72409/diff/1/?file=2224549#file2224549line30>
> >
> > What do you mean for "task is specified with executor ID"? Why do we want to specify an executor ID for a task?
>
> Greg Mann wrote:
> In the LAUNCH_GROUP call, one or more tasks is specified along with an executor info, so there is always an executor ID specified.
>
> Greg Mann wrote:
> I updated the text to hopefully make this a little clearer, let me know what you think.
I see the updated text is:
> When one task is specified with an executor that has a unique executor ID
But IIUC, for the `LAUNCH_GROUP` call, the executor is not specified to the individual task (i.e., `TaskInfo.executor`) in the task group, instead it is specified in the `LaunchGroup` protobuf message, right?
```
message LaunchGroup {
required ExecutorInfo executor = 1;
required TaskGroupInfo task_group = 2;
}
```
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72409/#review220420
-----------------------------------------------------------
On April 28, 2020, 7:57 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72409/
> -----------------------------------------------------------
>
> (Updated April 28, 2020, 7:57 a.m.)
>
>
> Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim Harper.
>
>
> Bugs: MESOS-10115
> https://issues.apache.org/jira/browse/MESOS-10115
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds a new document containing an introduction for
> scheduler authors to the available methods for running
> workloads in a Mesos cluster.
>
>
> Diffs
> -----
>
> docs/home.md 027319fa28abbdac21588ad1c62dae588033f60e
> docs/running-workloads.md PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72409/diff/2/
>
>
> Testing
> -------
>
> Viewed with `site/mesos-website-dev.sh`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72409: Added intro docs on running workloads.
Posted by Greg Mann <gr...@mesosphere.io>.
> On April 22, 2020, 1:21 p.m., Qian Zhang wrote:
> > docs/running-workloads.md
> > Lines 30 (patched)
> > <https://reviews.apache.org/r/72409/diff/1/?file=2224549#file2224549line30>
> >
> > What do you mean for "task is specified with executor ID"? Why do we want to specify an executor ID for a task?
>
> Greg Mann wrote:
> In the LAUNCH_GROUP call, one or more tasks is specified along with an executor info, so there is always an executor ID specified.
I updated the text to hopefully make this a little clearer, let me know what you think.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72409/#review220420
-----------------------------------------------------------
On April 27, 2020, 11:57 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72409/
> -----------------------------------------------------------
>
> (Updated April 27, 2020, 11:57 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim Harper.
>
>
> Bugs: MESOS-10115
> https://issues.apache.org/jira/browse/MESOS-10115
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds a new document containing an introduction for
> scheduler authors to the available methods for running
> workloads in a Mesos cluster.
>
>
> Diffs
> -----
>
> docs/home.md 027319fa28abbdac21588ad1c62dae588033f60e
> docs/running-workloads.md PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72409/diff/2/
>
>
> Testing
> -------
>
> Viewed with `site/mesos-website-dev.sh`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72409: Added intro docs on running workloads.
Posted by Greg Mann <gr...@mesosphere.io>.
> On April 22, 2020, 1:21 p.m., Qian Zhang wrote:
> > docs/running-workloads.md
> > Lines 30 (patched)
> > <https://reviews.apache.org/r/72409/diff/1/?file=2224549#file2224549line30>
> >
> > What do you mean for "task is specified with executor ID"? Why do we want to specify an executor ID for a task?
>
> Greg Mann wrote:
> In the LAUNCH_GROUP call, one or more tasks is specified along with an executor info, so there is always an executor ID specified.
>
> Greg Mann wrote:
> I updated the text to hopefully make this a little clearer, let me know what you think.
>
> Qian Zhang wrote:
> I see the updated text is:
> > When one task is specified with an executor that has a unique executor ID
>
> But IIUC, for the `LAUNCH_GROUP` call, the executor is not specified to the individual task (i.e., `TaskInfo.executor`) in the task group, instead it is specified in the `LaunchGroup` protobuf message, right?
> ```
> message LaunchGroup {
> required ExecutorInfo executor = 1;
> required TaskGroupInfo task_group = 2;
> }
> ```
Yes, I think the language "one task is specified with an executor" makes sense in that context.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72409/#review220420
-----------------------------------------------------------
On April 27, 2020, 11:57 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72409/
> -----------------------------------------------------------
>
> (Updated April 27, 2020, 11:57 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim Harper.
>
>
> Bugs: MESOS-10115
> https://issues.apache.org/jira/browse/MESOS-10115
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds a new document containing an introduction for
> scheduler authors to the available methods for running
> workloads in a Mesos cluster.
>
>
> Diffs
> -----
>
> docs/home.md 027319fa28abbdac21588ad1c62dae588033f60e
> docs/running-workloads.md PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72409/diff/2/
>
>
> Testing
> -------
>
> Viewed with `site/mesos-website-dev.sh`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72409: Added intro docs on running workloads.
Posted by Greg Mann <gr...@mesosphere.io>.
> On April 22, 2020, 1:21 p.m., Qian Zhang wrote:
> > docs/running-workloads.md
> > Lines 30 (patched)
> > <https://reviews.apache.org/r/72409/diff/1/?file=2224549#file2224549line30>
> >
> > What do you mean for "task is specified with executor ID"? Why do we want to specify an executor ID for a task?
>
> Greg Mann wrote:
> In the LAUNCH_GROUP call, one or more tasks is specified along with an executor info, so there is always an executor ID specified.
>
> Greg Mann wrote:
> I updated the text to hopefully make this a little clearer, let me know what you think.
>
> Qian Zhang wrote:
> I see the updated text is:
> > When one task is specified with an executor that has a unique executor ID
>
> But IIUC, for the `LAUNCH_GROUP` call, the executor is not specified to the individual task (i.e., `TaskInfo.executor`) in the task group, instead it is specified in the `LaunchGroup` protobuf message, right?
> ```
> message LaunchGroup {
> required ExecutorInfo executor = 1;
> required TaskGroupInfo task_group = 2;
> }
> ```
>
> Greg Mann wrote:
> Yes, I think the language "one task is specified with an executor" makes sense in that context.
Hm, maybe I'll change it to "one task is specified alongside an executor" to make the distinction clearer?
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72409/#review220420
-----------------------------------------------------------
On April 27, 2020, 11:57 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72409/
> -----------------------------------------------------------
>
> (Updated April 27, 2020, 11:57 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim Harper.
>
>
> Bugs: MESOS-10115
> https://issues.apache.org/jira/browse/MESOS-10115
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds a new document containing an introduction for
> scheduler authors to the available methods for running
> workloads in a Mesos cluster.
>
>
> Diffs
> -----
>
> docs/home.md 027319fa28abbdac21588ad1c62dae588033f60e
> docs/running-workloads.md PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72409/diff/2/
>
>
> Testing
> -------
>
> Viewed with `site/mesos-website-dev.sh`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72409: Added intro docs on running workloads.
Posted by Greg Mann <gr...@mesosphere.io>.
> On April 22, 2020, 1:21 p.m., Qian Zhang wrote:
> > docs/running-workloads.md
> > Lines 30 (patched)
> > <https://reviews.apache.org/r/72409/diff/1/?file=2224549#file2224549line30>
> >
> > What do you mean for "task is specified with executor ID"? Why do we want to specify an executor ID for a task?
In the LAUNCH_GROUP call, one or more tasks is specified along with an executor info, so there is always an executor ID specified.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72409/#review220420
-----------------------------------------------------------
On April 21, 2020, 8 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72409/
> -----------------------------------------------------------
>
> (Updated April 21, 2020, 8 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim Harper.
>
>
> Bugs: MESOS-10115
> https://issues.apache.org/jira/browse/MESOS-10115
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds a new document containing an introduction for
> scheduler authors to the available methods for running
> workloads in a Mesos cluster.
>
>
> Diffs
> -----
>
> docs/home.md 027319fa28abbdac21588ad1c62dae588033f60e
> docs/running-workloads.md PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72409/diff/1/
>
>
> Testing
> -------
>
> Viewed with `site/mesos-website-dev.sh`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72409: Added intro docs on running workloads.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72409/#review220420
-----------------------------------------------------------
docs/running-workloads.md
Lines 30 (patched)
<https://reviews.apache.org/r/72409/#comment308804>
What do you mean for "task is specified with executor ID"? Why do we want to specify an executor ID for a task?
docs/running-workloads.md
Lines 37 (patched)
<https://reviews.apache.org/r/72409/#comment308805>
We already support CNI network per nested container, so task in a task group can either share network from executor or have its own network.
docs/running-workloads.md
Lines 190 (patched)
<https://reviews.apache.org/r/72409/#comment308808>
Do we need to mention that `share_cgroups` can not be set to false in the command task case?
- Qian Zhang
On April 22, 2020, 4 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72409/
> -----------------------------------------------------------
>
> (Updated April 22, 2020, 4 a.m.)
>
>
> Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim Harper.
>
>
> Bugs: MESOS-10115
> https://issues.apache.org/jira/browse/MESOS-10115
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds a new document containing an introduction for
> scheduler authors to the available methods for running
> workloads in a Mesos cluster.
>
>
> Diffs
> -----
>
> docs/home.md 027319fa28abbdac21588ad1c62dae588033f60e
> docs/running-workloads.md PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72409/diff/1/
>
>
> Testing
> -------
>
> Viewed with `site/mesos-website-dev.sh`
>
>
> Thanks,
>
> Greg Mann
>
>