You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Wei Zhou <w....@leaseweb.com> on 2013/02/08 11:14:12 UTC

Review Request: (CLOUDSTACK-1211) Network operations are Blocked for the Read-only file system of Virtual Router

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9384/
-----------------------------------------------------------

Review request for cloudstack, Chip Childers and edison su.


Description
-------

The issue can be found at https://issues.apache.org/jira/browse/CLOUDSTACK-1211

please copy dist/systemvm.iso to /usr/lib/cloud/common/vms/systemvm.iso on host after building.
and restart cloud-agent service.


This addresses bug CLOUDSTACK-1211.


Diffs
-----

  apache-cloudstack-4.0.0-incubating-src/patches/systemvm/debian/config/root/func.sh 4047a40 

Diff: https://reviews.apache.org/r/9384/diff/


Testing
-------

Before change:
(1) Acquire IP. always in "Allocating" state. 
(2) EnableStaticNat, the result is success(it is incorrect). 
(3) DisableStaticNat, will get error message.. This is correct. 
(4) Add Firewalls. always in "Adding" state. 
(5) The AgentManager report statistics every 60 minutes(normally it should be router.stats.interval=5 minutes).

After change:
(1) Acquire IP, will get error message.
(2) EnableStaticNat, will get error message.
(3) DisableStaticNat, will get error message.
(4) Add Firewalls, will get error message. But the firewall rules are saved in database.
(5) The AgentManager report statistics every 5 minutes, except the network with read-only FS virtual router.


Thanks,

Wei Zhou


RE: Review Request: (CLOUDSTACK-1211) Network operations are Blocked for the Read-only file system of Virtual Router

Posted by Animesh Chaturvedi <an...@citrix.com>.
Chiradeep, Edison

Can you review this patch and apply if it looks good

> -----Original Message-----
> From: Wei Zhou [mailto:noreply@reviews.apache.org] On Behalf Of Wei Zhou
> Sent: Friday, February 08, 2013 2:14 AM
> To: Chip Childers; Edison Su
> Cc: cloudstack; Wei Zhou
> Subject: Review Request: (CLOUDSTACK-1211) Network operations are Blocked
> for the Read-only file system of Virtual Router
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9384/
> -----------------------------------------------------------
> 
> Review request for cloudstack, Chip Childers and edison su.
> 
> 
> Description
> -------
> 
> The issue can be found at https://issues.apache.org/jira/browse/CLOUDSTACK-
> 1211
> 
> please copy dist/systemvm.iso to /usr/lib/cloud/common/vms/systemvm.iso on
> host after building.
> and restart cloud-agent service.
> 
> 
> This addresses bug CLOUDSTACK-1211.
> 
> 
> Diffs
> -----
> 
>   apache-cloudstack-4.0.0-incubating-
> src/patches/systemvm/debian/config/root/func.sh 4047a40
> 
> Diff: https://reviews.apache.org/r/9384/diff/
> 
> 
> Testing
> -------
> 
> Before change:
> (1) Acquire IP. always in "Allocating" state.
> (2) EnableStaticNat, the result is success(it is incorrect).
> (3) DisableStaticNat, will get error message.. This is correct.
> (4) Add Firewalls. always in "Adding" state.
> (5) The AgentManager report statistics every 60 minutes(normally it should be
> router.stats.interval=5 minutes).
> 
> After change:
> (1) Acquire IP, will get error message.
> (2) EnableStaticNat, will get error message.
> (3) DisableStaticNat, will get error message.
> (4) Add Firewalls, will get error message. But the firewall rules are saved in
> database.
> (5) The AgentManager report statistics every 5 minutes, except the network
> with read-only FS virtual router.
> 
> 
> Thanks,
> 
> Wei Zhou


RE: Review Request: (CLOUDSTACK-1211) Network operations are Blocked for the Read-only file system of Virtual Router

Posted by Animesh Chaturvedi <an...@citrix.com>.
Edison

Thanks for your review. Please commit the patch; update comments with commit details and move the review to submitted state

> -----Original Message-----
> From: edison su [mailto:noreply@reviews.apache.org] On Behalf Of edison su
> Sent: Tuesday, February 12, 2013 9:24 AM
> To: Chip Childers; Edison Su
> Cc: cloudstack; Wei Zhou
> Subject: Re: Review Request: (CLOUDSTACK-1211) Network operations are
> Blocked for the Read-only file system of Virtual Router
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9384/#review16469
> -----------------------------------------------------------
> 
> Ship it!
> 
> 
> Ship It!
> 
> - edison su
> 
> 
> On Feb. 8, 2013, 10:14 a.m., Wei Zhou wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/9384/
> > -----------------------------------------------------------
> >
> > (Updated Feb. 8, 2013, 10:14 a.m.)
> >
> >
> > Review request for cloudstack, Chip Childers and edison su.
> >
> >
> > Description
> > -------
> >
> > The issue can be found at
> https://issues.apache.org/jira/browse/CLOUDSTACK-1211
> >
> > please copy dist/systemvm.iso to /usr/lib/cloud/common/vms/systemvm.iso
> on host after building.
> > and restart cloud-agent service.
> >
> >
> > This addresses bug CLOUDSTACK-1211.
> >
> >
> > Diffs
> > -----
> >
> >   apache-cloudstack-4.0.0-incubating-
> src/patches/systemvm/debian/config/root/func.sh 4047a40
> >
> > Diff: https://reviews.apache.org/r/9384/diff/
> >
> >
> > Testing
> > -------
> >
> > Before change:
> > (1) Acquire IP. always in "Allocating" state.
> > (2) EnableStaticNat, the result is success(it is incorrect).
> > (3) DisableStaticNat, will get error message.. This is correct.
> > (4) Add Firewalls. always in "Adding" state.
> > (5) The AgentManager report statistics every 60 minutes(normally it should
> be router.stats.interval=5 minutes).
> >
> > After change:
> > (1) Acquire IP, will get error message.
> > (2) EnableStaticNat, will get error message.
> > (3) DisableStaticNat, will get error message.
> > (4) Add Firewalls, will get error message. But the firewall rules are saved in
> database.
> > (5) The AgentManager report statistics every 5 minutes, except the network
> with read-only FS virtual router.
> >
> >
> > Thanks,
> >
> > Wei Zhou
> >
> >


Re: Review Request: (CLOUDSTACK-1211) Network operations are Blocked for the Read-only file system of Virtual Router

Posted by edison su <ed...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9384/#review16469
-----------------------------------------------------------

Ship it!


Ship It!

- edison su


On Feb. 8, 2013, 10:14 a.m., Wei Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9384/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2013, 10:14 a.m.)
> 
> 
> Review request for cloudstack, Chip Childers and edison su.
> 
> 
> Description
> -------
> 
> The issue can be found at https://issues.apache.org/jira/browse/CLOUDSTACK-1211
> 
> please copy dist/systemvm.iso to /usr/lib/cloud/common/vms/systemvm.iso on host after building.
> and restart cloud-agent service.
> 
> 
> This addresses bug CLOUDSTACK-1211.
> 
> 
> Diffs
> -----
> 
>   apache-cloudstack-4.0.0-incubating-src/patches/systemvm/debian/config/root/func.sh 4047a40 
> 
> Diff: https://reviews.apache.org/r/9384/diff/
> 
> 
> Testing
> -------
> 
> Before change:
> (1) Acquire IP. always in "Allocating" state. 
> (2) EnableStaticNat, the result is success(it is incorrect). 
> (3) DisableStaticNat, will get error message.. This is correct. 
> (4) Add Firewalls. always in "Adding" state. 
> (5) The AgentManager report statistics every 60 minutes(normally it should be router.stats.interval=5 minutes).
> 
> After change:
> (1) Acquire IP, will get error message.
> (2) EnableStaticNat, will get error message.
> (3) DisableStaticNat, will get error message.
> (4) Add Firewalls, will get error message. But the firewall rules are saved in database.
> (5) The AgentManager report statistics every 5 minutes, except the network with read-only FS virtual router.
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>