You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/09/11 23:16:16 UTC

[GitHub] codecov-io edited a comment on issue #5861: [SIP-6] removed get_data for BigNumber

codecov-io edited a comment on issue #5861: [SIP-6] removed get_data for BigNumber
URL: https://github.com/apache/incubator-superset/pull/5861#issuecomment-420456619
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5861?src=pr&el=h1) Report
   > Merging [#5861](https://codecov.io/gh/apache/incubator-superset/pull/5861?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6df720d873f455e3518f56e026f7270a12b95171?src=pr&el=desc) will **decrease** coverage by `14.32%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/5861/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/5861?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #5861       +/-   ##
   ===========================================
   - Coverage   77.99%   63.66%   -14.33%     
   ===========================================
     Files          46      376      +330     
     Lines        9312    23337    +14025     
     Branches        0     2612     +2612     
   ===========================================
   + Hits         7263    14858     +7595     
   - Misses       2049     8466     +6417     
   - Partials        0       13       +13
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5861?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/5861/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `81.18% <ø> (-0.11%)` | :arrow_down: |
   | [.../assets/src/visualizations/BigNumber/BigNumber.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5861/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9CaWdOdW1iZXIvQmlnTnVtYmVyLmpzeA==) | `0% <0%> (ø)` | |
   | [...erset/assets/src/visualizations/BigNumber/index.js](https://codecov.io/gh/apache/incubator-superset/pull/5861/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9CaWdOdW1iZXIvaW5kZXguanM=) | `0% <0%> (ø)` | |
   | [...et/assets/src/visualizations/BigNumber/adaptor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5861/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9CaWdOdW1iZXIvYWRhcHRvci5qc3g=) | `0% <0%> (ø)` | |
   | [...sets/src/explore/components/ExploreChartHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5861/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvRXhwbG9yZUNoYXJ0SGVhZGVyLmpzeA==) | `71.42% <0%> (ø)` | |
   | [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5861/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==) | `100% <0%> (ø)` | |
   | [...perset/assets/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/5861/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9nZXRFbXB0eUxheW91dC5qcw==) | `0% <0%> (ø)` | |
   | [...ts/src/dashboard/util/getComponentWidthFromDrop.js](https://codecov.io/gh/apache/incubator-superset/pull/5861/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9nZXRDb21wb25lbnRXaWR0aEZyb21Ecm9wLmpz) | `96.15% <0%> (ø)` | |
   | [...erset/assets/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5861/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9RdWVyeVNlYXJjaC5qc3g=) | `69.36% <0%> (ø)` | |
   | [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5861/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvQW5ub3RhdGlvbkxheWVyLmpzeA==) | `22.92% <0%> (ø)` | |
   | ... and [324 more](https://codecov.io/gh/apache/incubator-superset/pull/5861/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5861?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5861?src=pr&el=footer). Last update [6df720d...509b140](https://codecov.io/gh/apache/incubator-superset/pull/5861?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org