You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by jtstorck <gi...@git.apache.org> on 2018/08/06 17:09:41 UTC

[GitHub] nifi pull request #2937: NIFI-4434 Fixed recursive listing with a custom reg...

GitHub user jtstorck opened a pull request:

    https://github.com/apache/nifi/pull/2937

    NIFI-4434 Fixed recursive listing with a custom regex filter.

    Filter modes are now supported to perform listings based on directory and file names, file-names only, and full path.
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jtstorck/nifi NIFI-4434

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2937.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2937
    
----
commit 6f525bf2b84603f10fd52141e7bff6af68c61f6f
Author: Jeff Storck <jt...@...>
Date:   2018-08-01T17:13:40Z

    NIFI-4434 Fixed recursive listing with a custom regex filter.
    Filter modes are now supported to perform listings based on directory and file names, file-names only, and full path.

----


---

[GitHub] nifi issue #2937: NIFI-4434 Fixed recursive listing with a custom regex filt...

Posted by zenfenan <gi...@git.apache.org>.

Github user zenfenan commented on the issue:

    https://github.com/apache/nifi/pull/2937
  
    +1 Thanks @jtstorck. Merged to the master. Thanks @ottobackwards for reviewing.


---

[GitHub] nifi issue #2937: NIFI-4434 Fixed recursive listing with a custom regex filt...

Posted by jtstorck <gi...@git.apache.org>.

Github user jtstorck commented on the issue:

    https://github.com/apache/nifi/pull/2937
  
    @ottobackwards Regarding documentation for the filter modes, descriptions have been created for the allowable values.  Do these descriptions not seem adequate for the functionality of each mode?


---

[GitHub] nifi pull request #2937: NIFI-4434 Fixed recursive listing with a custom reg...

Posted by jtstorck <gi...@git.apache.org>.

Github user jtstorck commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2937#discussion_r208072541
  
    --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/ListHDFS.java ---
    @@ -462,11 +523,15 @@ private String getPerms(final FsAction action) {
     
         private PathFilter createPathFilter(final ProcessContext context) {
             final Pattern filePattern = Pattern.compile(context.getProperty(FILE_FILTER).getValue());
    --- End diff --
    
    @ottobackwards The FILE_FILTER property does not currently support expression language.  The processor could be updated to enable EL for the property, but that is outside the scope of this PR.


---