You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@linkis.apache.org by GitBox <gi...@apache.org> on 2022/05/13 07:02:44 UTC
[GitHub] [incubator-linkis] xiaojie19852006 opened a new pull request, #2109: Add Sqoop Engine
xiaojie19852006 opened a new pull request, #2109:
URL: https://github.com/apache/incubator-linkis/pull/2109
### What is the purpose of the change
Add Sqoop Engine
### Brief change log
(for example:)
- Define sqoop engine;
### Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- Anything that affects deployment: no
### Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone commented on a diff in pull request #2109: Add Sqoop Engine
Posted by GitBox <gi...@apache.org>.
casionone commented on code in PR #2109:
URL: https://github.com/apache/incubator-linkis/pull/2109#discussion_r872358820
##########
LICENSE-binary:
##########
@@ -576,6 +576,7 @@ See licenses-binary/ for text of these licenses.
(Apache License, version 2.0) Apache ZooKeeper - Server (org.apache.zookeeper:zookeeper:3.4.6 - https://zookeeper.apache.org/)
(Apache License, version 2.0) Apache twill (org.apache.twill:* - https://twill.apache.org/)
(Apache License, version 2.0) Apache tephra (co.cask.tephra:* - https://tephra.apache.org/)
+ (Apache License, version 2.0) Apache Sqoop - Server (org.apache.sqoop:sqoop:1.4.6 - https://github.com/apache/sqoop/)
Review Comment:
LICENSE-sqoop.txt should be added to licenses-binary/LICENSE-sqoop.txt
just as https://github.com/apache/incubator-linkis/pull/2035/files#diff-38e53776e6465b9057e805920c3ec9de556ff1a4595b8c86724845411f91d312
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] codecov[bot] commented on pull request #2109: Add Sqoop Engine
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #2109:
URL: https://github.com/apache/incubator-linkis/pull/2109#issuecomment-1125736575
# [Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/2109?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2109](https://codecov.io/gh/apache/incubator-linkis/pull/2109?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (39ba76d) into [dev-1.1.2](https://codecov.io/gh/apache/incubator-linkis/commit/c953223afe1b80df8074dae7355a4cba6f0c8285?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c953223) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## dev-1.1.2 #2109 +/- ##
============================================
Coverage 18.45% 18.45%
Complexity 703 703
============================================
Files 344 344
Lines 10723 10723
Branches 1608 1608
============================================
Hits 1979 1979
Misses 8539 8539
Partials 205 205
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/2109?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/2109?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c953223...39ba76d](https://codecov.io/gh/apache/incubator-linkis/pull/2109?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] Davidhua1996 merged pull request #2109: Add Sqoop Engine
Posted by GitBox <gi...@apache.org>.
Davidhua1996 merged PR #2109:
URL: https://github.com/apache/incubator-linkis/pull/2109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org