[GitHub] [pinot] siddharthteotia commented on a diff in pull request #10587: [multistage] Add support for the ranking ROW_NUMBER() window function

["siddharthteotia (via GitHub)" <gi...@apache.org>]

siddharthteotia commented on code in PR #10587:
URL: https://github.com/apache/pinot/pull/10587#discussion_r1170575291


##########
pinot-query-planner/src/test/resources/queries/WindowFunctionPlans.json:
##########
@@ -1107,6 +1323,22 @@
           "\n"
         ]

Review Comment:
   Can we also cover the subquery style in the plans ?
   
   Something like 
   
   ```
   SELECT * FROM (
       SELECT 
           ROW_NUMBER() OVER (.....) rn, 
           c1, 
           c2, 
           c3
       FROM
           foo
       ) temp    
   WHERE
       rn > 10 AND rn <=20;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org