You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/19 04:20:25 UTC

[GitHub] [spark] dchvn commented on pull request #34318: [SPARK-37048][PYTHON] Clean up inlining type hints under SQL module

dchvn commented on pull request #34318:
URL: https://github.com/apache/spark/pull/34318#issuecomment-946354661


   I think some other places may be cleaned up too. Thank you!
   
   https://github.com/ueshin/apache-spark/blob/2f175be8acb44aa793519fc8f50b2cc3830350a6/python/pyspark/sql/streaming.py#L322
   
   https://github.com/ueshin/apache-spark/blob/2f175be8acb44aa793519fc8f50b2cc3830350a6/python/pyspark/sql/dataframe.py#L109
   https://github.com/ueshin/apache-spark/blob/2f175be8acb44aa793519fc8f50b2cc3830350a6/python/pyspark/sql/dataframe.py#L1280
   https://github.com/ueshin/apache-spark/blob/2f175be8acb44aa793519fc8f50b2cc3830350a6/python/pyspark/sql/dataframe.py#L1654
   https://github.com/ueshin/apache-spark/blob/2f175be8acb44aa793519fc8f50b2cc3830350a6/python/pyspark/sql/dataframe.py#L1658
   
   https://github.com/ueshin/apache-spark/blob/2f175be8acb44aa793519fc8f50b2cc3830350a6/python/pyspark/sql/context.py#L37
   https://github.com/ueshin/apache-spark/blob/2f175be8acb44aa793519fc8f50b2cc3830350a6/python/pyspark/sql/context.py#L124
   https://github.com/ueshin/apache-spark/blob/2f175be8acb44aa793519fc8f50b2cc3830350a6/python/pyspark/sql/context.py#L730
   
   https://github.com/ueshin/apache-spark/blob/2f175be8acb44aa793519fc8f50b2cc3830350a6/python/pyspark/sql/readwriter.py#L362
   https://github.com/ueshin/apache-spark/blob/2f175be8acb44aa793519fc8f50b2cc3830350a6/python/pyspark/sql/readwriter.py#L575
   https://github.com/ueshin/apache-spark/blob/2f175be8acb44aa793519fc8f50b2cc3830350a6/python/pyspark/sql/readwriter.py#L787
   https://github.com/ueshin/apache-spark/blob/2f175be8acb44aa793519fc8f50b2cc3830350a6/python/pyspark/sql/readwriter.py#L852
   https://github.com/ueshin/apache-spark/blob/2f175be8acb44aa793519fc8f50b2cc3830350a6/python/pyspark/sql/readwriter.py#L902
   https://github.com/ueshin/apache-spark/blob/2f175be8acb44aa793519fc8f50b2cc3830350a6/python/pyspark/sql/readwriter.py#L1389


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org