You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by jg...@apache.org on 2018/11/26 14:50:44 UTC
[5/6] tomee git commit: removes redudant toString
removes redudant toString
Project: http://git-wip-us.apache.org/repos/asf/tomee/repo
Commit: http://git-wip-us.apache.org/repos/asf/tomee/commit/806df6dc
Tree: http://git-wip-us.apache.org/repos/asf/tomee/tree/806df6dc
Diff: http://git-wip-us.apache.org/repos/asf/tomee/diff/806df6dc
Branch: refs/heads/master
Commit: 806df6dc4095d0d444357b242560d182544fa69f
Parents: e859469
Author: Otavio Santana <ot...@gmail.com>
Authored: Thu Nov 22 16:26:57 2018 -0200
Committer: Otavio Santana <ot...@gmail.com>
Committed: Thu Nov 22 16:26:57 2018 -0200
----------------------------------------------------------------------
.../main/java/org/apache/openejb/monitoring/ObjectNameBuilder.java | 2 +-
.../java/org/apache/openejb/resource/AutoConnectionTracker.java | 2 +-
.../java/org/apache/openejb/loader/provisining/MavenResolver.java | 2 +-
.../java/org/apache/tomee/webapp/installer/InstallerServlet.java | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/tomee/blob/806df6dc/container/openejb-core/src/main/java/org/apache/openejb/monitoring/ObjectNameBuilder.java
----------------------------------------------------------------------
diff --git a/container/openejb-core/src/main/java/org/apache/openejb/monitoring/ObjectNameBuilder.java b/container/openejb-core/src/main/java/org/apache/openejb/monitoring/ObjectNameBuilder.java
index 8a02206..ab52dbe 100644
--- a/container/openejb-core/src/main/java/org/apache/openejb/monitoring/ObjectNameBuilder.java
+++ b/container/openejb-core/src/main/java/org/apache/openejb/monitoring/ObjectNameBuilder.java
@@ -66,7 +66,7 @@ public class ObjectNameBuilder {
return new ObjectName(sb.toString());
} catch (final MalformedObjectNameException e) {
- throw new IllegalStateException("Failed to build valid name for: " + sb.toString(), e);
+ throw new IllegalStateException("Failed to build valid name for: " + sb, e);
}
}
http://git-wip-us.apache.org/repos/asf/tomee/blob/806df6dc/container/openejb-core/src/main/java/org/apache/openejb/resource/AutoConnectionTracker.java
----------------------------------------------------------------------
diff --git a/container/openejb-core/src/main/java/org/apache/openejb/resource/AutoConnectionTracker.java b/container/openejb-core/src/main/java/org/apache/openejb/resource/AutoConnectionTracker.java
index 49f891e..d9f4618 100644
--- a/container/openejb-core/src/main/java/org/apache/openejb/resource/AutoConnectionTracker.java
+++ b/container/openejb-core/src/main/java/org/apache/openejb/resource/AutoConnectionTracker.java
@@ -140,7 +140,7 @@ public class AutoConnectionTracker implements ConnectionTracker {
sb.append("\n ").append("Connection handle opened at ").append(stackTraceToString(connectionInfo.getTrace().getStackTrace()));
}
- logger.warning("Transaction complete, but connection still has handles associated: " + managedConnectionInfo + "\nAbandoned connection information: " + sb.toString());
+ logger.warning("Transaction complete, but connection still has handles associated: " + managedConnectionInfo + "\nAbandoned connection information: " + sb);
}
}
}
http://git-wip-us.apache.org/repos/asf/tomee/blob/806df6dc/container/openejb-loader/src/main/java/org/apache/openejb/loader/provisining/MavenResolver.java
----------------------------------------------------------------------
diff --git a/container/openejb-loader/src/main/java/org/apache/openejb/loader/provisining/MavenResolver.java b/container/openejb-loader/src/main/java/org/apache/openejb/loader/provisining/MavenResolver.java
index b335614..2f8c60d 100644
--- a/container/openejb-loader/src/main/java/org/apache/openejb/loader/provisining/MavenResolver.java
+++ b/container/openejb-loader/src/main/java/org/apache/openejb/loader/provisining/MavenResolver.java
@@ -281,7 +281,7 @@ public class MavenResolver implements ArchiveResolver, ProvisioningResolverAware
parser.parse(metadata, handler);
if (handler.timestamp != null && handler.buildNumber != null) {
return defaultVersion.substring(0, defaultVersion.length() - SNAPSHOT_SUFFIX.length())
- + "-" + handler.timestamp.toString() + "-" + handler.buildNumber.toString();
+ + "-" + handler.timestamp + "-" + handler.buildNumber;
}
} catch (final Exception e) {
// no-op: not parseable so ignoring
http://git-wip-us.apache.org/repos/asf/tomee/blob/806df6dc/tomee/tomee-webapp/src/main/java/org/apache/tomee/webapp/installer/InstallerServlet.java
----------------------------------------------------------------------
diff --git a/tomee/tomee-webapp/src/main/java/org/apache/tomee/webapp/installer/InstallerServlet.java b/tomee/tomee-webapp/src/main/java/org/apache/tomee/webapp/installer/InstallerServlet.java
index 8bf7aac..03d5765 100644
--- a/tomee/tomee-webapp/src/main/java/org/apache/tomee/webapp/installer/InstallerServlet.java
+++ b/tomee/tomee-webapp/src/main/java/org/apache/tomee/webapp/installer/InstallerServlet.java
@@ -49,7 +49,7 @@ public class InstallerServlet extends HttpServlet {
if (!list.isEmpty()) {
sb.deleteCharAt(sb.length() - 1);
}
- return "[" + sb.toString() + "]";
+ return "[" + sb + "]";
}
@Override