[GitHub] [guacamole-client] necouchman commented on a change in pull request #492: GUACAMOLE-728: Add SSL configuration options for MySQL and PostgreSQL

[GitBox <gi...@apache.org>]

necouchman commented on a change in pull request #492:
URL: https://github.com/apache/guacamole-client/pull/492#discussion_r440939358



##########
File path: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-mysql/src/main/java/org/apache/guacamole/auth/mysql/MySQLAuthenticationProviderModule.java
##########
@@ -79,6 +84,37 @@ public MySQLAuthenticationProviderModule(MySQLEnvironment environment)
         // Allow use of multiple statements within a single query
         driverProperties.setProperty("allowMultiQueries", "true");
         
+        // Set the SSL mode to use when conncting
+        MySQLSSLMode sslMode = environment.getMySQLSSLMode();
+        driverProperties.setProperty("sslMode", sslMode.toString());
+        
+        // Set legacy properties
+        if (sslMode == MySQLSSLMode.DISABLED)
+            driverProperties.setProperty("useSSL", "false");

Review comment:
       I think so - basically, the only case where `useSSL` will be set to `false` will be where `sslMode` is already set to `disabled`.  In every other case of `sslMode`, `useSSL` will be set to `true`, which, based on some feedback and documentation, is required for different (older) versions of MySQL and/or MariaDB.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org