You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/08/27 12:49:00 UTC
[jira] [Commented] (FLINK-10207) Bump checkstyle-plugin to 8.9
[ https://issues.apache.org/jira/browse/FLINK-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16593604#comment-16593604 ]
ASF GitHub Bot commented on FLINK-10207:
----------------------------------------
zentol opened a new pull request #6618: [FLINK-10207][build] Bump checkstyle to 8.9
URL: https://github.com/apache/flink/pull/6618
## What is the purpose of the change
This PR bumps the checkstyle version to 8.9, which is a prerequisite for compiling with java 9.
## Brief change log
* bump version to 8.9
* updated IDE setup docs
* fixed a number of checkstyle violations that weren't detected previously
## Verifying this change
I had to setup a local VM with jdk 9 to encounter the issue and verify the fix. Travis is unfortunately unreliable for this, as some jdk 9 incompatibilities that I encountered locally didn't occur on travis (which is actually **very** problematic).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Bump checkstyle-plugin to 8.9
> -----------------------------
>
> Key: FLINK-10207
> URL: https://issues.apache.org/jira/browse/FLINK-10207
> Project: Flink
> Issue Type: Sub-task
> Components: Build System
> Affects Versions: 1.7.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> Our current checkstyle version (8.4) is incompatible with java 9, the earliest version to work properly is 8.9.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)