You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by cc...@apache.org on 2016/09/22 02:11:50 UTC

[2/3] incubator-mynewt-newt git commit: newt - Comment indicating intent to fix bug.

newt - Comment indicating intent to fix bug.


Project: http://git-wip-us.apache.org/repos/asf/incubator-mynewt-newt/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-mynewt-newt/commit/84303b54
Tree: http://git-wip-us.apache.org/repos/asf/incubator-mynewt-newt/tree/84303b54
Diff: http://git-wip-us.apache.org/repos/asf/incubator-mynewt-newt/diff/84303b54

Branch: refs/heads/develop
Commit: 84303b5422b93bae12dea78ff3f11a8c01197847
Parents: 0ae71ef
Author: Christopher Collins <cc...@apache.org>
Authored: Wed Sep 14 19:36:38 2016 -0700
Committer: Christopher Collins <cc...@apache.org>
Committed: Wed Sep 14 19:36:38 2016 -0700

----------------------------------------------------------------------
 newt/syscfg/syscfg.go | 3 +++
 1 file changed, 3 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-mynewt-newt/blob/84303b54/newt/syscfg/syscfg.go
----------------------------------------------------------------------
diff --git a/newt/syscfg/syscfg.go b/newt/syscfg/syscfg.go
index c94abfb..5d62b0e 100644
--- a/newt/syscfg/syscfg.go
+++ b/newt/syscfg/syscfg.go
@@ -218,6 +218,9 @@ func readOnce(cfg Cfg, lpkg *pkg.LocalPackage) error {
 				appendValue(&entry, lpkg, v)
 				cfg[k] = entry
 			} else {
+				// XXX: We should not warn until the final iteration.  These
+				// settings may get defined later after dependencies are
+				// unlocked by additional settings.
 				log.Warnf("ignoring override of undefined setting; "+
 					"%s sets %s=%+v", lpkg.Name(), k, v)
 			}