You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by si...@apache.org on 2011/04/04 20:17:48 UTC

svn commit: r1088693 - /commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/tools/DiscoverSingleton.java

Author: simonetripodi
Date: Mon Apr  4 18:17:48 2011
New Revision: 1088693

URL: http://svn.apache.org/viewvc?rev=1088693&view=rev
Log:
fixed checkstyle violations

Modified:
    commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/tools/DiscoverSingleton.java

Modified: commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/tools/DiscoverSingleton.java
URL: http://svn.apache.org/viewvc/commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/tools/DiscoverSingleton.java?rev=1088693&r1=1088692&r2=1088693&view=diff
==============================================================================
--- commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/tools/DiscoverSingleton.java (original)
+++ commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/tools/DiscoverSingleton.java Mon Apr  4 18:17:48 2011
@@ -211,6 +211,7 @@ public class DiscoverSingleton {
     /**
      * Find implementation of SPI.
      *
+     * @param <T>  Service Provider Interface type.
      * @param spiClass Service Provider Interface Class.
      *
      * @return Instance of a class implementing the SPI.
@@ -232,6 +233,8 @@ public class DiscoverSingleton {
     /**
      * Find implementation of SPI.
      *
+     * @param <T> Service Provider Interface type
+     *
      * @param spiClass Service Provider Interface Class.
      *
      * @param properties Used to determine name of SPI implementation,
@@ -257,6 +260,8 @@ public class DiscoverSingleton {
     /**
      * Find implementation of SPI.
      *
+     * @param <T> Service Provider Interface type
+     *
      * @param spiClass Service Provider Interface Class.
      *
      * @param defaultImpl Default implementation.
@@ -280,6 +285,8 @@ public class DiscoverSingleton {
     /**
      * Find implementation of SPI.
      *
+     * @param <T> Service Provider Interface type
+     *
      * @param spiClass Service Provider Interface Class.
      *
      * @param properties Used to determine name of SPI implementation,
@@ -309,6 +316,8 @@ public class DiscoverSingleton {
     /**
      * Find implementation of SPI.
      *
+     * @param <T> Service Provider Interface type
+     *
      * @param spiClass Service Provider Interface Class.
      *
      * @param propertiesFileName Used to determine name of SPI implementation,
@@ -342,6 +351,10 @@ public class DiscoverSingleton {
     /**
      * Find implementation of SPI.
      *
+     * @param <T> Service Provider Interface type
+     *
+     * @param loaders The {@code ClassLoader} holder
+     *
      * @param spi Service Provider Interface Class.
      *
      * @param properties Used to determine name of SPI implementation,
@@ -407,6 +420,8 @@ public class DiscoverSingleton {
      * instance associated with the current thread context class loader.
      * If the SPI instance implements <code>Service</code>, then call
      * <code>release()</code>.
+     *
+     * @param spiClass The previously created service
      */
     public static synchronized void release(Class<?> spiClass) {
         Map<String, Object> spis = EnvironmentCache.get(JDKHooks.getJDKHooks().getThreadContextClassLoader());
@@ -467,6 +482,10 @@ public class DiscoverSingleton {
 
     /**
      * Put service keyed by spi & classLoader.
+     *
+     * @param classLoader The {@link EnvironmentCache} key
+     * @param spiName The SPI class name
+     * @param service The SPI object reference
      */
     private static synchronized void put(ClassLoader classLoader,
                                          String spiName,