[jira] [Commented] (FLINK-29422) Production tests return/argument types do not take transitivity into account

["Chesnay Schepler (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-29422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17609965#comment-17609965 ] 

Chesnay Schepler commented on FLINK-29422:
------------------------------------------

Alright this is "solved" for the IterativeCondition with an exclusion. _great_

> Production tests return/argument types do not take transitivity into account
> ----------------------------------------------------------------------------
>
>                 Key: FLINK-29422
>                 URL: https://issues.apache.org/jira/browse/FLINK-29422
>             Project: Flink
>          Issue Type: Technical Debt
>          Components: API / DataStream
>    Affects Versions: 1.16.0
>            Reporter: Chesnay Schepler
>            Priority: Major
>
> In FLINK-29403 I'm marking {{SimpleCondition}} as {{PublicEvolving}}, but the production tests reject it:
> {code:java}
> Architecture Violation [Priority: MEDIUM] - Rule 'Return and argument types of methods annotated with @PublicEvolving must be annotated with @Public(Evolving).' was violated (1 times):
> Sep 26 15:20:12 org.apache.flink.cep.pattern.conditions.SimpleCondition.filter(java.lang.Object, org.apache.flink.cep.pattern.conditions.IterativeCondition$Context): Argument leaf type org.apache.flink.cep.pattern.conditions.IterativeCondition$Context does not satisfy: reside outside of package 'org.apache.flink..' or reside in any package ['..shaded..'] or annotated with @Public or annotated with @PublicEvolving or annotated with @Deprecated
> {code}
> This doesn't make any sense given that {{IterativeCondition}} itself is already {{PublicEvolving}} and contains the exact same method.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)