You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2023/01/12 11:14:51 UTC

[GitHub] [spark] LuciferYang commented on a diff in pull request #39531: [SPARK-42029][CONNECT] Add Guava Shading rules to `connect-common` to avoid startup failure

LuciferYang commented on code in PR #39531:
URL: https://github.com/apache/spark/pull/39531#discussion_r1067997804


##########
connector/connect/common/pom.xml:
##########
@@ -156,6 +156,43 @@
                     </execution>
                 </executions>
             </plugin>
+            <!-- Shade all GRPC / Guava / Protobuf dependencies of this build -->
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-shade-plugin</artifactId>
+                <configuration>
+                    <shadedArtifactAttached>false</shadedArtifactAttached>
+                    <artifactSet>

Review Comment:
   If `connect-common.jar` will not be used independently, I guess it can be used only by configuring the `relocations` rule(same as `connect` module), the `artifactSet` doesn't need to be configured.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org