[jira] [Commented] (GEODE-3544) JSON parsing error while key having the short data type & Key class have some part in base class

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-3544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16148969#comment-16148969 ] 

ASF GitHub Bot commented on GEODE-3544:
---------------------------------------

GitHub user dineshakhand opened a pull request:

    https://github.com/apache/geode/pull/752

    GEODE-3544

    JSON parsing failed for short data type & base class setting is not used
    when key having base class
    
    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
    
    - [ X] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
    
    - [ X] Is your initial contribution a single, squashed commit?
    
    - [ X] Does `gradlew build` run cleanly?
    
    - [ X] Have you written or updated unit tests to verify your changes?
    
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
    submit an update to your PR as soon as possible. If you need help, please send an
    email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dineshakhand/geode feature/GEODE-3544

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/752.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #752
    
----
commit 2874f5f3f0429a9e40f4baa41727d14f74034844
Author: dineshpune2006 <di...@gmail.com>
Date:   2017-08-31T13:18:36Z

    GEODE-3544
    
    JSON parsing failed for short data type & base class setting is not used
    when key having base class

----


> JSON parsing error while key having the short data type & Key class have some part in base class
> ------------------------------------------------------------------------------------------------
>
>                 Key: GEODE-3544
>                 URL: https://issues.apache.org/jira/browse/GEODE-3544
>             Project: Geode
>          Issue Type: Bug
>          Components: gfsh
>            Reporter: dineshakhand
>
> JSON parsing error while region key 
> having the short data type.
> example :
> Processkey{
> int id;
> long pid,
> short cid;
> }
> JSON is not able to parse short data type . default it consider it as integer.
> while in the class setter method will have the data type short.
> second issue :  JSON parsing only consider the Key class method not the base class setter method.
> if key class have BASE class .  then it parse only derived class method.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)