You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2019/08/15 15:31:00 UTC
[jira] [Commented] (NIFI-6416)
WriteAheadFlowFileRepository.swapFlowFilesIn() not removing
swapLocationSuffixes
[ https://issues.apache.org/jira/browse/NIFI-6416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16908193#comment-16908193 ]
ASF subversion and git services commented on NIFI-6416:
-------------------------------------------------------
Commit 5f696482b06b868c88a96cf6666e21642dea386b in nifi's branch refs/heads/master from Brandon Rhys DeVries
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=5f69648 ]
NIFI-4775: Updating documentation and updating rocksdb version
NIFI-4775: Rolling back fix for NIFI-6416
NIFI-4775: Documentation improvements
+1 from markobean
This closes #3648
Signed-off-by: Brandon <de...@apache.org>
> WriteAheadFlowFileRepository.swapFlowFilesIn() not removing swapLocationSuffixes
> --------------------------------------------------------------------------------
>
> Key: NIFI-6416
> URL: https://issues.apache.org/jira/browse/NIFI-6416
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Reporter: Brandon DeVries
> Priority: Minor
>
> WriteAheadFlowFileRepository maintains a list of swapLocationSuffixes. This is added to when records are swapped out, and removed from when records are swapped in when the repo is updated[1]. However, the swapFlowFilesIn method[2] appears to be adding instead of removing the specified swap location.
> Specifically:
> {code:java}
> synchronized (this.swapLocationSuffixes) {
> this.swapLocationSuffixes.add(normalizeSwapLocation(swapLocation));
> }{code}
> Should be:
> {code:java}
> synchronized (this.swapLocationSuffixes) {
> this.swapLocationSuffixes.remove(normalizeSwapLocation(swapLocation));
> }{code}
>
>
> [1] [https://github.com/apache/nifi/blob/f08c2ee43f39584b7d4e76d61d7d4aaa889068fd/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/WriteAheadFlowFileRepository.java#L372-L377]
> [2] [https://github.com/apache/nifi/blob/f08c2ee43f39584b7d4e76d61d7d4aaa889068fd/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/WriteAheadFlowFileRepository.java#L518]
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)