You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/02/24 12:08:14 UTC
[GitHub] [incubator-inlong] kipshi opened a new pull request #2705: [INLONG-2676] AgentTask support stop|restart|finish
kipshi opened a new pull request #2705:
URL: https://github.com/apache/incubator-inlong/pull/2705
### Title Name: [INLONG-XYZ][component] Title of the pull request
where *XYZ* should be replaced by the actual issue number.
Fixes #2676
### Motivation
AgentTask support stop|restart|finish
### Modifications
AgentTask support stop|restart|finish
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a change in pull request #2705: [INLONG-2676][Manager] Support stop / restart / finish agent task
Posted by GitBox <gi...@apache.org>.
healchow commented on a change in pull request #2705:
URL: https://github.com/apache/incubator-inlong/pull/2705#discussion_r814697046
##########
File path: inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/source/SourceRequest.java
##########
@@ -68,4 +68,6 @@
@ApiModelProperty("Heartbeat of the source task")
private String heartbeat;
+ @ApiModelProperty("Status")
Review comment:
It's not recommended to add a status field in the request.
Operations that modify status should be encapsulated into a separate interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow merged pull request #2705: [INLONG-2676][Manager] Support stop / restart / finish agent task
Posted by GitBox <gi...@apache.org>.
healchow merged pull request #2705:
URL: https://github.com/apache/incubator-inlong/pull/2705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org