You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/11/28 16:18:07 UTC
[GitHub] [flink] zentol commented on a change in pull request #10341:
[FLINK-14974][runtime] Calculate managed memory fractions with BigDecimal
and round down it properly
zentol commented on a change in pull request #10341: [FLINK-14974][runtime] Calculate managed memory fractions with BigDecimal and round down it properly
URL: https://github.com/apache/flink/pull/10341#discussion_r351863075
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
##########
@@ -771,7 +774,7 @@ private static void setManagedMemoryFractionForSlotSharingGroup(
private static void setManagedMemoryFractionForOperator(
final ResourceSpec operatorResourceSpec,
final ResourceSpec groupResourceSpec,
- final int groupOperatorCount,
+ final long groupOperatorCount,
Review comment:
Is the int not automatically promoted to a long when calling `BigDecimal.valueOf()`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services