You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "codecov-commenter (via GitHub)" <gi...@apache.org> on 2023/02/23 02:18:31 UTC
[GitHub] [pinot] codecov-commenter commented on pull request #10321: Refactor Spark Connector into two modules for reusability
codecov-commenter commented on PR #10321:
URL: https://github.com/apache/pinot/pull/10321#issuecomment-1441136929
# [Codecov](https://codecov.io/gh/apache/pinot/pull/10321?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#10321](https://codecov.io/gh/apache/pinot/pull/10321?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (94be858) into [master](https://codecov.io/gh/apache/pinot/commit/0f2d51cc80e2bdfcd73bbf8cc75a1b2ab214e722?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0f2d51c) will **decrease** coverage by `56.60%`.
> The diff coverage is `34.28%`.
```diff
@@ Coverage Diff @@
## master #10321 +/- ##
=============================================
- Coverage 70.42% 13.82% -56.60%
+ Complexity 5103 243 -4860
=============================================
Files 2017 1986 -31
Lines 109181 107846 -1335
Branches 16602 16447 -155
=============================================
- Hits 76887 14912 -61975
- Misses 26901 91737 +64836
+ Partials 5393 1197 -4196
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `?` | |
| integration2 | `?` | |
| unittests1 | `?` | |
| unittests2 | `13.82% <34.28%> (+0.12%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/10321?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pache/pinot/connector/spark/common/HttpUtils.scala](https://codecov.io/gh/apache/pinot/pull/10321?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29ubmVjdG9ycy9waW5vdC1zcGFyay1jb21tb24vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9waW5vdC9jb25uZWN0b3Ivc3BhcmsvY29tbW9uL0h0dHBVdGlscy5zY2FsYQ==) | `0.00% <ø> (ø)` | |
| [.../apache/pinot/connector/spark/common/Logging.scala](https://codecov.io/gh/apache/pinot/pull/10321?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29ubmVjdG9ycy9waW5vdC1zcGFyay1jb21tb24vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9waW5vdC9jb25uZWN0b3Ivc3BhcmsvY29tbW9uL0xvZ2dpbmcuc2NhbGE=) | `6.66% <ø> (ø)` | |
| [...ot/connector/spark/common/PinotClusterClient.scala](https://codecov.io/gh/apache/pinot/pull/10321?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29ubmVjdG9ycy9waW5vdC1zcGFyay1jb21tb24vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9waW5vdC9jb25uZWN0b3Ivc3BhcmsvY29tbW9uL1Bpbm90Q2x1c3RlckNsaWVudC5zY2FsYQ==) | `5.15% <0.00%> (ø)` | |
| [...ache/pinot/connector/spark/common/exceptions.scala](https://codecov.io/gh/apache/pinot/pull/10321?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29ubmVjdG9ycy9waW5vdC1zcGFyay1jb21tb24vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9waW5vdC9jb25uZWN0b3Ivc3BhcmsvY29tbW9uL2V4Y2VwdGlvbnMuc2NhbGE=) | `20.00% <ø> (ø)` | |
| [.../apache/pinot/connector/spark/common/package.scala](https://codecov.io/gh/apache/pinot/pull/10321?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29ubmVjdG9ycy9waW5vdC1zcGFyay1jb21tb24vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9waW5vdC9jb25uZWN0b3Ivc3BhcmsvY29tbW9uL3BhY2thZ2Uuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
| [...pinot/connector/spark/common/query/ScanQuery.scala](https://codecov.io/gh/apache/pinot/pull/10321?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29ubmVjdG9ycy9waW5vdC1zcGFyay1jb21tb24vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9waW5vdC9jb25uZWN0b3Ivc3BhcmsvY29tbW9uL3F1ZXJ5L1NjYW5RdWVyeS5zY2FsYQ==) | `57.14% <0.00%> (ø)` | |
| [...k/common/reader/PinotAbstractPartitionReader.scala](https://codecov.io/gh/apache/pinot/pull/10321?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29ubmVjdG9ycy9waW5vdC1zcGFyay1jb21tb24vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9waW5vdC9jb25uZWN0b3Ivc3BhcmsvY29tbW9uL3JlYWRlci9QaW5vdEFic3RyYWN0UGFydGl0aW9uUmVhZGVyLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...ark/common/reader/PinotGrpcServerDataFetcher.scala](https://codecov.io/gh/apache/pinot/pull/10321?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29ubmVjdG9ycy9waW5vdC1zcGFyay1jb21tb24vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9waW5vdC9jb25uZWN0b3Ivc3BhcmsvY29tbW9uL3JlYWRlci9QaW5vdEdycGNTZXJ2ZXJEYXRhRmV0Y2hlci5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
| [...r/spark/common/reader/PinotServerDataFetcher.scala](https://codecov.io/gh/apache/pinot/pull/10321?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29ubmVjdG9ycy9waW5vdC1zcGFyay1jb21tb24vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9waW5vdC9jb25uZWN0b3Ivc3BhcmsvY29tbW9uL3JlYWRlci9QaW5vdFNlcnZlckRhdGFGZXRjaGVyLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...nnector/spark/common/CaseInsensitiveStringMap.java](https://codecov.io/gh/apache/pinot/pull/10321?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29ubmVjdG9ycy9waW5vdC1zcGFyay1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L2Nvbm5lY3Rvci9zcGFyay9jb21tb24vQ2FzZUluc2Vuc2l0aXZlU3RyaW5nTWFwLmphdmE=) | `35.41% <35.41%> (ø)` | |
| ... and [1635 more](https://codecov.io/gh/apache/pinot/pull/10321?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org