[GitHub] [echarts] susiwen8 commented on a change in pull request #15677: Fix(MarkerLine): convert date string to timestamp

[GitBox <gi...@apache.org>]

susiwen8 commented on a change in pull request #15677:
URL: https://github.com/apache/echarts/pull/15677#discussion_r702399781



##########
File path: src/data/DataStore.ts
##########
@@ -408,9 +409,13 @@ class DataStore {
                 for (let dimIdx = 0; dimIdx < dimLen; dimIdx++) {
                     const dimStorage = chunks[dimIdx];
                     // PENDING NULL is empty or zero
-                    const val = this._dimValueGetter(
+                    let val = this._dimValueGetter(
                         dataItem, dimNames[dimIdx], idx, dimIdx
                     ) as ParsedValueNumeric;
+
+                    if (this._dimensions[dimIdx].type === 'time') {

Review comment:
       ```js
   const a = new Float64Array();
   a[0] = '2018-01-02';
   console.log(a) // [NaN]
   ```
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org