You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Adam B <ad...@mesosphere.io> on 2015/08/04 11:29:00 UTC
Re: Review Request 36816: Support HTTP checks in Mesos health check
program
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36816/#review93562
-----------------------------------------------------------
src/health-check/main.cpp (line 242)
<https://reviews.apache.org/r/36816/#comment147942>
Why is this comment relevant here? You aren't even mentioning https here. I'd remove it.
include/mesos/mesos.proto (line 207)
<https://reviews.apache.org/r/36816/#comment147943>
s/compile/is compiled/
- Adam B
On Aug. 4, 2015, 2:28 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36816/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2015, 2:28 a.m.)
>
>
> Review request for mesos, Adam B and Michael Park.
>
>
> Bugs: MESOS-2533
> https://issues.apache.org/jira/browse/MESOS-2533
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Support HTTP checks in Mesos health check program
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto a6748d1cd82238f005c6a49c70d22d095462f1ba
> src/health-check/main.cpp 97b25716335ec5719c1100bd73d06b7fc98036c9
> src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea
>
> Diff: https://reviews.apache.org/r/36816/diff/
>
>
> Testing
> -------
>
> * Add a new unit test: HealthCheckTest.HealthyTaskThroughHttp
> make check
>
>
> Thanks,
>
> haosdent huang
>
>