You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/04/14 00:14:40 UTC

[GitHub] [incubator-tvm] soiferj commented on issue #5310: [BYOC] Enhance partitioning and external codegen

soiferj commented on issue #5310: [BYOC] Enhance partitioning and external codegen
URL: https://github.com/apache/incubator-tvm/pull/5310#issuecomment-613158127
 
 
   Hi all, sorry for being late to the party, it's been a really busy last couple of months. I was just pulling these changes and trying them out, and I have a question on the handling of constants. @zhiics, is there a reason why you copy the entire content of the constants instead of just using the value of the pointer?
   
   In other words, instead of `float const_1[1000] = {......}`, we could have `float* const_1 = dl_tensor.data`. We can pass that pointer around directly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services