You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by dhalperi <gi...@git.apache.org> on 2017/04/04 22:36:58 UTC

[GitHub] beam pull request #2428: [BEAM-1880] DataflowPipelineJob: handle concurrent ...

GitHub user dhalperi opened a pull request:

    https://github.com/apache/beam/pull/2428

    [BEAM-1880] DataflowPipelineJob: handle concurrent cancel and finish

    This makes job.cancel() not throw an exception if cancel() is called while job is finished.
    (Note that state.isTerminal() is not guaranteed to be up to date.)
    
    R: @jkff 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhalperi/beam streaming-cancellation

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2428.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2428
    
----
commit 0cb835585006334a6d3f31c7acfbd926543a08d4
Author: Dan Halperin <dh...@google.com>
Date:   2017-04-04T22:33:21Z

    DataflowPipelineJob: handle concurrent cancel and finish
    
    This makes job.cancel() not throw an exception if cancel() is called while job is finished.
    (Note that state.isTerminal() is not guaranteed to be up to date.)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] beam pull request #2428: [BEAM-1880] DataflowPipelineJob: handle concurrent ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/2428


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---