[GitHub] [nuttx] jlaitine commented on a diff in pull request #8242: nuttx: apply misc fixes in code noticed during code review

["jlaitine (via GitHub)" <gi...@apache.org>]

jlaitine commented on code in PR #8242:
URL: https://github.com/apache/nuttx/pull/8242#discussion_r1088299172


##########
fs/shm/shm_open.c:
##########
@@ -165,7 +166,7 @@ int shm_open(FAR const char *name, int oflag, mode_t mode)
   if (ret < 0)
     {
       set_errno(-ret);
-      return -1;
+      return ERROR;

Review Comment:
   This is matter of opinion of course,but I find these changes confusing. Posix spec says that the function is supposed to return -1. Not "ERROR", which is nuttx internal define.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org