[jira] [Commented] (HDFS-11925) Offline Image Viewer: Processor argument should have some verification

["genericqa (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-11925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16379738#comment-16379738 ] 

genericqa commented on HDFS-11925:
----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  5s{color} | {color:red} HDFS-11925 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HDFS-11925 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12871179/HDFS-11925.patch |
| Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/23233/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> Offline Image Viewer: Processor argument should have some verification
> ----------------------------------------------------------------------
>
>                 Key: HDFS-11925
>                 URL: https://issues.apache.org/jira/browse/HDFS-11925
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: tools
>    Affects Versions: 3.0.0-alpha3
>            Reporter: LiXin Ge
>            Assignee: LiXin Ge
>            Priority: Major
>         Attachments: HDFS-11925.patch
>
>
> At present, hdfs oiv tool lacks in verification of input parameter.people can type in irrelevant option like:
> bq. ./hdfs oiv -i fsimage_0000000000000000000 -p XML -step 1024
> or type in option with wrong format which he think come into effec but actually not: 
> bq. ./hdfs oiv -i fsimage_0000000000000000000 -p FileDistribution maxSize 4096 step 512 format
> or some meaningless word which can also get through:
> bq. ./hdfs oiv -i fsimage_0000000000000000000 -p XML Hello Han Meimei
> We'd better not let these cases go unchecked. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org