You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/06/09 06:22:16 UTC
[GitHub] [superset] wengieeee opened a new pull request, #20325: fix(sqllab):clickhouse result no column header
wengieeee opened a new pull request, #20325:
URL: https://github.com/apache/superset/pull/20325
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
version : superset 1.5.0
python : 3.8
connect db：clickhouse + **http**（8123）
if you run any clickhouse sql with "**format**" keyword， returned results have no column headers，the first row of results will be the column header。
In this case, if the first column has a null value, an error will be thrown directly。
After troubleshooting, the problem lies in the referenced package clickhouse_sqlalchemy/drivers/http/connector.py:112
Therefore, the SQL with format keyword needs to add format parameters “FORMAT TabSeparatedWithNamesAndTypes” manually
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before
after
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
1、run any clickhouse sql with "format" keyword. like
`select subtractDays(toDateTime(formatDateTime(now(),'%Y-%m-%d 00:00:00')),2) as t`
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
Fixes #19253
- [x] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [x] Introduces new feature or API
- [x] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro closed pull request #20325: fix(sqllab):clickhouse result no column header
Posted by GitBox <gi...@apache.org>.
villebro closed pull request #20325: fix(sqllab):clickhouse result no column header
URL: https://github.com/apache/superset/pull/20325
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] save-my-heart commented on pull request #20325: fix(sqllab):clickhouse result no column header
Posted by GitBox <gi...@apache.org>.
save-my-heart commented on PR #20325:
URL: https://github.com/apache/superset/pull/20325#issuecomment-1156051555
I think it is not necessary to rewrite query in superset. Instead, fix it in clickhouse_sqlalchemy.
See: https://github.com/xzkostyan/clickhouse-sqlalchemy/pull/180
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #20325: fix(sqllab):clickhouse result no column header
Posted by GitBox <gi...@apache.org>.
villebro commented on PR #20325:
URL: https://github.com/apache/superset/pull/20325#issuecomment-1229820425
Superseded by #21195, closing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] phpsxg commented on pull request #20325: fix(sqllab):clickhouse result no column header
Posted by GitBox <gi...@apache.org>.
phpsxg commented on PR #20325:
URL: https://github.com/apache/superset/pull/20325#issuecomment-1179514195
Why clickhouse result no column header when using formatDateTime function,Thanks~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org