[GitHub] [airflow] potiuk commented on a change in pull request #20272: Fix mypy typing for airflow/models and their tests

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #20272:
URL: https://github.com/apache/airflow/pull/20272#discussion_r768217117



##########
File path: airflow/models/baseoperator.py
##########
@@ -567,6 +567,13 @@ def __init__(
         self.email = email
         self.email_on_retry = email_on_retry
         self.email_on_failure = email_on_failure
+        self.execution_timeout = execution_timeout
+        self.on_execute_callback = on_execute_callback
+        self.on_failure_callback = on_failure_callback
+        self.on_success_callback = on_success_callback
+        self.on_retry_callback = on_retry_callback
+        self._pre_execute_hook = pre_execute
+        self._post_execute_hook = post_execute

Review comment:
       
   I think this was the reason (self passed to logging which potentially reads all self fields):
   
   ```
   self.log.warning("Implicitly converting 'retries' for %s from %r to int", self, retries)
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org