[jira] [Commented] (IGNITE-6064) Rework control.sh script

["Dmitriy Setrakyan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-6064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16126962#comment-16126962 ] 

Dmitriy Setrakyan commented on IGNITE-6064:
-------------------------------------------

1. name - how about "cluster-ops.sh" or "cluster-switch.sh"?
2. Printing help in case of error is not enough. You should print an error message first, and then help. See how other Ignite scripts work.
3. The stack trace should never be printed, not just for failed connection. We should always provide an appropriate error message and possible reasons for it. Perhaps you can add a "--verbose" mode to your script which will print all the stack traces as well.


> Rework control.sh script
> ------------------------
>
>                 Key: IGNITE-6064
>                 URL: https://issues.apache.org/jira/browse/IGNITE-6064
>             Project: Ignite
>          Issue Type: Improvement
>          Components: general
>    Affects Versions: 2.0, 2.1
>            Reporter: Dmitriy Govorukhin
>             Fix For: 2.2
>
>
> Current behavior control.sh is not clear.
> 1. control.sh is a confusing name, need more suitable name.
> 2. Print help description if  incorrect command was entered
> 3. Do not print stacktrace if connection fail, add more conveniently message.
> 4. Print information about connection, like "Connecting to [ip-address]:[port] etc."



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)