You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2024/11/07 10:09:00 UTC
[PR] HDDS-11634. Publish images to Docker Hub from GitHub workflow [ozone-docker-runner]
adoroszlai opened a new pull request, #33:
URL: https://github.com/apache/ozone-docker-runner/pull/33
## What changes were proposed in this pull request?
Publish `ozone-runner` Docker images created by the CI workflow to Docker Hub, in addition to existing practice.
Only publish images with tags, not by Git commit SHA (the latter is used only for GitHub Container Registry).
https://issues.apache.org/jira/browse/HDDS-11634
## How was this patch tested?
```
git tag test-HDDS-11634
git push adoroszlai test-HDDS-11634
```
[Workflow](https://github.com/adoroszlai/ozone-docker-runner/actions/runs/11720643164/job/32646418482) published the image to both [GitHub](https://github.com/adoroszlai/ozone-docker-runner/pkgs/container/ozone-runner/301804159?tag=test-HDDS-11634) and [Docker Hub](https://hub.docker.com/layers/adoroszlai/ozone-runner/test-HDDS-11634/images/sha256-4f8b2ab305a3fbc3f4602f5f7dc2f9a76c8c6659b610a806c8391b1398580802?context=explore).
Secrets set by Apache Infra on this repo will be tested when this is merged and the commit tagged.
Once we confirm this to be working, we can ask Infra to disable the Docker Hub automated build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11634. Publish images to Docker Hub from GitHub workflow [ozone-docker-runner]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #33:
URL: https://github.com/apache/ozone-docker-runner/pull/33#issuecomment-2461855066
I just noticed that the image pushed by tag only has amd64 platform. Will reopen this once I fix that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11634. Publish images to Docker Hub from GitHub workflow [ozone-docker-runner]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #33:
URL: https://github.com/apache/ozone-docker-runner/pull/33
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11634. Publish images to Docker Hub from GitHub workflow [ozone-docker-runner]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai closed pull request #33: HDDS-11634. Publish images to Docker Hub from GitHub workflow
URL: https://github.com/apache/ozone-docker-runner/pull/33
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11634. Publish images to Docker Hub from GitHub workflow [ozone-docker-runner]
Posted by "smengcl (via GitHub)" <gi...@apache.org>.
smengcl commented on PR #33:
URL: https://github.com/apache/ozone-docker-runner/pull/33#issuecomment-2463859413
Thanks @adoroszlai for the patch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11634. Publish images to Docker Hub from GitHub workflow [ozone-docker-runner]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #33:
URL: https://github.com/apache/ozone-docker-runner/pull/33#issuecomment-2461980065
Fixed tagging of multi-arch images:
https://github.com/adoroszlai/ozone-docker-runner/pkgs/container/ozone-runner/301857641?tag=test2-HDDS-11634
https://hub.docker.com/layers/adoroszlai/ozone-runner/test2-HDDS-11634/images/sha256-3c0e370f7459b049ba55864f65497e243da0f6de42b7a47ae4fdcd3e41fbd4bb?context=explore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11634. Publish images to Docker Hub from GitHub workflow [ozone-docker-runner]
Posted by "smengcl (via GitHub)" <gi...@apache.org>.
smengcl commented on code in PR #33:
URL: https://github.com/apache/ozone-docker-runner/pull/33#discussion_r1833411962
##########
.github/workflows/build-and-tag.yaml:
##########
@@ -33,18 +33,25 @@ jobs:
if: ${{ github.ref_type == 'tag' }}
runs-on: ubuntu-latest
env:
+ DOCKERHUB_USER: ${{ secrets.DOCKERHUB_USER }}
IMAGE_ID: ${{ needs.build.outputs.image-id }}
+ REGISTRIES: ghcr.io # docker.io is appended dynamically
steps:
- name: Generate tags
uses: docker/metadata-action@8e5442c4ef9f78752691e2d8f8d19755c6f78e81
with:
images: |
- ghcr.io/${{ github.repository_owner }}/ozone-runner
+ ${{ github.repository_owner }}/ozone-runner
tags: |
type=ref,event=tag
flavor: |
latest=false
+ - name: Add Docker Hub to targets
+ if: ${{ env.DOCKERHUB_USER }}
+ run: |
+ echo "REGISTRIES=${{ env.REGISTRIES}} docker.io" >> $GITHUB_ENV
Review Comment:
nit
```suggestion
echo "REGISTRIES=${{ env.REGISTRIES }} docker.io" >> $GITHUB_ENV
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11634. Publish images to Docker Hub from GitHub workflow [ozone-docker-runner]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #33:
URL: https://github.com/apache/ozone-docker-runner/pull/33#issuecomment-2463834803
Thanks @smengcl for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org