You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/04/26 18:00:30 UTC
[GitHub] [incubator-nuttx] gustavonihei opened a new pull request #3610: ESP32-C3: Add driver for the general purpose SPI peripheral in master mode
gustavonihei opened a new pull request #3610:
URL: https://github.com/apache/incubator-nuttx/pull/3610
## Summary
This PR intends to add support for the GPSPI2 peripheral as Master.
For now, **only Polling mode** is available.
## Impact
New feature for the ESP32-C3 chip, no impact to existing configs.
## Testing
This functionality has been validated with `SPITool` application on the ESP32-C3 DevKit by looping back MOSI and MISO pins on GPSPI2, both using IOMUX pins and routing through the GPIO Matrix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis merged pull request #3610: ESP32-C3: Add driver for the general purpose SPI peripheral in master mode
Posted by GitBox <gi...@apache.org>.
acassis merged pull request #3610:
URL: https://github.com/apache/incubator-nuttx/pull/3610
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a change in pull request #3610: ESP32-C3: Add driver for the general purpose SPI peripheral in master mode
Posted by GitBox <gi...@apache.org>.
acassis commented on a change in pull request #3610:
URL: https://github.com/apache/incubator-nuttx/pull/3610#discussion_r620727809
##########
File path: boards/risc-v/esp32c3/esp32c3-devkit/src/esp32c3_bringup.c
##########
@@ -161,6 +165,17 @@ int esp32c3_bringup(void)
}
#endif
+#ifdef CONFIG_SPI_DRIVER
Review comment:
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a change in pull request #3610: ESP32-C3: Add driver for the general purpose SPI peripheral in master mode
Posted by GitBox <gi...@apache.org>.
acassis commented on a change in pull request #3610:
URL: https://github.com/apache/incubator-nuttx/pull/3610#discussion_r620610330
##########
File path: boards/risc-v/esp32c3/esp32c3-devkit/src/esp32c3_bringup.c
##########
@@ -161,6 +165,17 @@ int esp32c3_bringup(void)
}
#endif
+#ifdef CONFIG_SPI_DRIVER
Review comment:
maybe in this case using: #if defined(CONFIG_SPI_DRIVER) && defined(CONFIG_ESP32C3_SPI2) will make the code cleaner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3610: ESP32-C3: Add driver for the general purpose SPI peripheral in master mode
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #3610:
URL: https://github.com/apache/incubator-nuttx/pull/3610#discussion_r620623831
##########
File path: boards/risc-v/esp32c3/esp32c3-devkit/src/esp32c3_bringup.c
##########
@@ -161,6 +165,17 @@ int esp32c3_bringup(void)
}
#endif
+#ifdef CONFIG_SPI_DRIVER
Review comment:
Thanks for the suggestion! Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org