You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/12/09 07:25:17 UTC

[GitHub] [dubbo-go] codecov-io edited a comment on pull request #758: fix #750. registry center notify with complete address list

codecov-io edited a comment on pull request #758:
URL: https://github.com/apache/dubbo-go/pull/758#issuecomment-726488883


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/758?src=pr&el=h1) Report
   > Merging [#758](https://codecov.io/gh/apache/dubbo-go/pull/758?src=pr&el=desc) (51ee140) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/25ed35dbcf25569e8cd045ab95550690e4076403?el=desc) (25ed35d) will **increase** coverage by `0.48%`.
   > The diff coverage is `60.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/758/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/758?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #758      +/-   ##
   ===========================================
   + Coverage    59.85%   60.33%   +0.48%     
   ===========================================
     Files          260      260              
     Lines        12854    12829      -25     
   ===========================================
   + Hits          7694     7741      +47     
   + Misses        4199     4129      -70     
   + Partials       961      959       -2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/758?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/758/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `60.33% <ø> (-3.09%)` | :arrow_down: |
   | [registry/nacos/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/758/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3Mvc2VydmljZV9kaXNjb3ZlcnkuZ28=) | `64.13% <0.00%> (-0.45%)` | :arrow_down: |
   | [registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/758/diff?src=pr&el=tree#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=) | `76.21% <0.00%> (-1.62%)` | :arrow_down: |
   | [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/758/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `80.90% <70.58%> (+6.89%)` | :arrow_up: |
   | [remoting/getty/config.go](https://codecov.io/gh/apache/dubbo-go/pull/758/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvY29uZmlnLmdv) | `9.85% <0.00%> (-5.26%)` | :arrow_down: |
   | [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/758/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `53.15% <0.00%> (-0.57%)` | :arrow_down: |
   | [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/758/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `66.66% <0.00%> (-0.50%)` | :arrow_down: |
   | [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/758/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `62.23% <0.00%> (-0.44%)` | :arrow_down: |
   | ... and [20 more](https://codecov.io/gh/apache/dubbo-go/pull/758/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/758?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/758?src=pr&el=footer). Last update [25ed35d...60f53ab](https://codecov.io/gh/apache/dubbo-go/pull/758?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org