You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "zhangjun0x01 (via GitHub)" <gi...@apache.org> on 2023/08/01 15:41:55 UTC
[GitHub] [incubator-paimon] zhangjun0x01 opened a new pull request, #1708: [flink] support bit type for flink sync job
zhangjun0x01 opened a new pull request, #1708:
URL: https://github.com/apache/incubator-paimon/pull/1708
<!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: close. https://github.com/apache/incubator-paimon/issues/1707
<!-- What is the purpose of the change -->
### Tests
<!-- List UT and IT cases to verify this change -->
### API and Format
<!-- Does this change affect API or storage format -->
### Documentation
<!-- Does this change introduce a new feature -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] zhangjun0x01 commented on a diff in pull request #1708: [flink] support bit type for flink sync job
Posted by "zhangjun0x01 (via GitHub)" <gi...@apache.org>.
zhangjun0x01 commented on code in PR #1708:
URL: https://github.com/apache/incubator-paimon/pull/1708#discussion_r1291128246
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/action/cdc/mysql/MySqlTypeUtils.java:
##########
@@ -152,6 +152,11 @@ public static DataType toDataType(
Boolean tinyInt1ToBool) {
switch (type.toUpperCase()) {
case BIT:
+ if (length == null || length == 1) {
+ return DataTypes.BOOLEAN();
Review Comment:
we refer to flink cdc , be consistent with flink cdc
https://ververica.github.io/flink-cdc-connectors/master/content/connectors/mysql-cdc.html#data-type-mapping.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] yuzelin commented on a diff in pull request #1708: [flink] support bit type for flink sync job
Posted by "yuzelin (via GitHub)" <gi...@apache.org>.
yuzelin commented on code in PR #1708:
URL: https://github.com/apache/incubator-paimon/pull/1708#discussion_r1291122645
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/action/cdc/mysql/MySqlTypeUtils.java:
##########
@@ -152,6 +152,11 @@ public static DataType toDataType(
Boolean tinyInt1ToBool) {
switch (type.toUpperCase()) {
case BIT:
+ if (length == null || length == 1) {
+ return DataTypes.BOOLEAN();
Review Comment:
Why cast bit(1) to boolean type?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi merged pull request #1708: [flink] support bit type for flink sync job
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #1708:
URL: https://github.com/apache/incubator-paimon/pull/1708
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org