You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/30 13:19:25 UTC

[GitHub] [airflow] pranjalmittal opened a new pull request #8644: 8565: SalesforceHook missing method to return dataframe

pranjalmittal opened a new pull request #8644:
URL: https://github.com/apache/airflow/pull/8644


   ---
   SalesforceHook function `write_object_to_file` is divided to `object_to_df` which returns a dataframe and then the `write_object_to_file` uses `object_to_df` as the first step before exporting to file.
   
   Issue: https://github.com/apache/airflow/issues/8565
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Target Github ISSUE in description if exists
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #8644: Added SalesforceHook missing method to return only dataframe (#8565)

Posted by GitBox <gi...@apache.org>.

potiuk merged pull request #8644:
URL: https://github.com/apache/airflow/pull/8644


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] pranjalmittal commented on pull request #8644: Added SalesforceHook missing method to return only dataframe (#8565)

Posted by GitBox <gi...@apache.org>.

pranjalmittal commented on pull request #8644:
URL: https://github.com/apache/airflow/pull/8644#issuecomment-628388867


   > Besides one comment LGTM 👍
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] pranjalmittal closed pull request #8644: Added SalesforceHook missing method to return only dataframe (#8565)

Posted by GitBox <gi...@apache.org>.

pranjalmittal closed pull request #8644:
URL: https://github.com/apache/airflow/pull/8644


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #8644: Added SalesforceHook missing method to return only dataframe (#8565)

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #8644:
URL: https://github.com/apache/airflow/pull/8644#issuecomment-629813205


   Awesome work, congrats on your first merged pull request!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #8644: 8565: SalesforceHook missing method to return dataframe

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #8644:
URL: https://github.com/apache/airflow/pull/8644#issuecomment-621830323

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] pranjalmittal removed a comment on pull request #8644: Added SalesforceHook missing method to return only dataframe (#8565)

Posted by GitBox <gi...@apache.org>.

pranjalmittal removed a comment on pull request #8644:
URL: https://github.com/apache/airflow/pull/8644#issuecomment-628388867


   > Besides one comment LGTM 👍
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] pranjalmittal commented on pull request #8644: Added SalesforceHook missing method to return only dataframe (#8565)

Posted by GitBox <gi...@apache.org>.

pranjalmittal commented on pull request #8644:
URL: https://github.com/apache/airflow/pull/8644#issuecomment-628389253


   @feluelle, I have fixed the comment, let me know if any other changes are required.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] pranjalmittal commented on a change in pull request #8644: Added SalesforceHook missing method to return only dataframe (#8565)

Posted by GitBox <gi...@apache.org>.

pranjalmittal commented on a change in pull request #8644:
URL: https://github.com/apache/airflow/pull/8644#discussion_r424872252



##########
File path: airflow/providers/salesforce/hooks/salesforce.py
##########
@@ -236,6 +236,61 @@ def write_object_to_file(self,
         if fmt not in ['csv', 'json', 'ndjson']:
             raise ValueError("Format value is not recognized: {}".format(fmt))
 
+        if filename is None:
+            raise ValueError("Filename cannot be None.")

Review comment:
       Added it as an additional check, removed it as the argument is not optional.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org