You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/08 17:45:42 UTC
[GitHub] [airflow] rafalh opened a new pull request #21430: Normalize *_conn_id parameters in BigQuery sensors
rafalh opened a new pull request #21430:
URL: https://github.com/apache/airflow/pull/21430
Add `gcp_conn_id` parameter to BigQuery sensors and deprecate `bigquery_conn_id` parameter.
Pass `gcp_conn_id` to `BigQueryHook` using `gcp_conn_id` to avoid deprecation warning in hook code.
Please note that a similar change for BigQuery operators was already performed in commit 042a9ba2c285772fcc2208847198c2e2c31d4424
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #21430: Normalize *_conn_id parameters in BigQuery sensors
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21430:
URL: https://github.com/apache/airflow/pull/21430#issuecomment-1040241245
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #21430: Normalize *_conn_id parameters in BigQuery sensors
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #21430:
URL: https://github.com/apache/airflow/pull/21430#discussion_r807210705
##########
File path: airflow/providers/google/cloud/sensors/bigquery.py
##########
@@ -64,25 +71,31 @@ def __init__(
project_id: str,
dataset_id: str,
table_id: str,
- bigquery_conn_id: str = 'google_cloud_default',
+ gcp_conn_id: str = 'google_cloud_default',
Review comment:
Just an idea for further improvement - maybe it would be good to introduce constant for this value and use it in all cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #21430: Normalize *_conn_id parameters in BigQuery sensors
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #21430:
URL: https://github.com/apache/airflow/pull/21430
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #21430: Normalize *_conn_id parameters in BigQuery sensors
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21430:
URL: https://github.com/apache/airflow/pull/21430#issuecomment-1040241245
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #21430: Normalize *_conn_id parameters in BigQuery sensors
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #21430:
URL: https://github.com/apache/airflow/pull/21430#discussion_r807214155
##########
File path: airflow/providers/google/cloud/sensors/bigquery.py
##########
@@ -64,25 +71,31 @@ def __init__(
project_id: str,
dataset_id: str,
table_id: str,
- bigquery_conn_id: str = 'google_cloud_default',
+ gcp_conn_id: str = 'google_cloud_default',
Review comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org